Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add CEL support in assertion trees #2029

Merged
merged 1 commit into from
Sep 28, 2024
Merged

feat: add CEL support in assertion trees #2029

merged 1 commit into from
Sep 28, 2024
+164 −144

Conversation

eddycharly
Copy link
Member

Explanation

Add CEL support in assertion trees.

@eddycharly
feat: add CEL support in assertion trees
Loading
Loading status checks…
8a9bca9 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly requested a review from a team as a code owner September 27, 2024 20:06
@eddycharly eddycharly added this to the v0.2.11 milestone Sep 27, 2024
@eddycharly
Copy link
Member Author

/cherry-pick release-0.2

@codecov Codecov
Copy link

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 67.37%. Comparing base (ba6a01a) to head (8a9bca9).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
pkg/runner/processors/step.go 75.00% 3 Missing ⚠️
pkg/apis/v1alpha1/types.go 0.00% 1 Missing ⚠️
pkg/engine/operations/internal/env.go 0.00% 1 Missing ⚠️
pkg/expressions/parse.go 87.50% 0 Missing and 1 partial ⚠️
pkg/expressions/string.go 80.00% 0 Missing and 1 partial ⚠️
pkg/expressions/string_pointer.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2029      +/-   ##
==========================================
- Coverage   67.44%   67.37%   -0.08%     
==========================================
  Files         137      137              
  Lines        6525     6529       +4     
==========================================
- Hits         4401     4399       -2     
- Misses       1806     1810       +4     
- Partials      318      320       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddycharly eddycharly merged commit 1d2d64b into kyverno:main Sep 28, 2024
16 of 17 checks passed
@eddycharly eddycharly deleted the cel-1 branch September 28, 2024 08:57
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 28, 2024
@eddycharly
feat: add CEL support in assertion trees (#2029)
125a063 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Sep 28, 2024
Merged
eddycharly added a commit that referenced this pull request Sep 28, 2024
@gcp-cherry-pick-bot @eddycharly
feat: add CEL support in assertion trees (#2029) (#2030)
39bf9e4 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cherry-pick completed cherry-pick required documentation required release notes completed release notes required
Projects
None yet
Milestone
v0.2.11
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@eddycharly