Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bindings support to step templates #1985

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

eddycharly
Copy link
Member

Explanation

Add bindings support to step templates.

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly added this to the v0.2.10 milestone Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 67.60%. Comparing base (01c20fb) to head (7ddaaac).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/discovery/load.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1985      +/-   ##
==========================================
- Coverage   67.62%   67.60%   -0.03%     
==========================================
  Files         136      136              
  Lines        6484     6486       +2     
==========================================
  Hits         4385     4385              
- Misses       1785     1787       +2     
  Partials      314      314              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
Copy link
Member Author

/cherry-pick release-0.2

@eddycharly eddycharly marked this pull request as ready for review September 16, 2024 12:35
@eddycharly eddycharly requested a review from a team as a code owner September 16, 2024 12:35
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly force-pushed the step-template-bindings branch from 57146a2 to 994f6bc Compare September 16, 2024 12:42
@eddycharly eddycharly merged commit ae96478 into kyverno:main Sep 16, 2024
12 checks passed
@eddycharly eddycharly deleted the step-template-bindings branch September 16, 2024 13:10
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 16, 2024
* feat: add bindings support to step templates

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

* fix comment

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>

---------

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
eddycharly added a commit that referenced this pull request Sep 16, 2024
* feat: add bindings support to step templates



* fix comment



---------

Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant