Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make template required in step template #1984

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix: make template required in step template #1984

merged 1 commit into from
Sep 16, 2024
+14 −10

Conversation

eddycharly
Copy link
Member

Explanation

Make template required in step template.

@eddycharly
fix: make template required in step template
Loading
Loading status checks…
414cff2 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly requested a review from a team as a code owner September 16, 2024 12:08
@eddycharly eddycharly added this to the v0.2.10 milestone Sep 16, 2024
@eddycharly
Copy link
Member Author

/cherry-pick release-0.2

@codecov Codecov
Copy link

codecov bot commented Sep 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.62%. Comparing base (0cd5fa6) to head (414cff2).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/discovery/load.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1984   +/-   ##
=======================================
  Coverage   67.62%   67.62%           
=======================================
  Files         136      136           
  Lines        6484     6484           
=======================================
  Hits         4385     4385           
  Misses       1785     1785           
  Partials      314      314

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddycharly eddycharly merged commit 351e47a into kyverno:main Sep 16, 2024
13 of 16 checks passed
@eddycharly eddycharly deleted the require-template branch September 16, 2024 12:17
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Sep 16, 2024
@eddycharly
fix: make template required in step template (#1984)
Loading
Loading status checks…
d62a40b 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Sep 16, 2024
Merged
eddycharly added a commit that referenced this pull request Sep 16, 2024
@gcp-cherry-pick-bot @eddycharly
fix: make template required in step template (#1984) (#1986)
Loading
Loading status checks…
3a1125a 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cherry-pick completed cherry-pick required documentation required release notes completed release notes required
Projects
None yet
Milestone
v0.2.10
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@eddycharly