refactor: decouple operation execution from failer #1958
Merged
+76
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cherry-pick release-0.2 |
eddycharly
force-pushed
the
refactor-op-exec
branch
from
e1aaa54 to
b51a083
Compare
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
eddycharly
force-pushed
the
refactor-op-exec
branch
from
b51a083 to
74ca0e1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1958 +/- ##
==========================================
- Coverage 69.32% 69.07% -0.26%
==========================================
Files 135 135
Lines 6292 6260 -32
==========================================
- Hits 4362 4324 -38
- Misses 1621 1626 +5
- Partials 309 310 +1 ☔ View full report in Codecov by Sentry. |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
eddycharly
added a commit
that referenced
this pull request
Sep 12, 2024
eddycharly
added a commit
to eddycharly/chainsaw
that referenced
this pull request
Sep 13, 2024
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
eddycharly
added a commit
that referenced
this pull request
Sep 13, 2024
eddycharly
added a commit
that referenced
this pull request
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Decouple operation execution from failer.