feat: Add workDir API to the script and command operation APIs to make parametrize the working directory #1913
+522
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metrize the working directory Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
|
@sergenyalcin did you see my reply on slack https://kubernetes.slack.com/archives/C067LUFL43U/p1725360878442449 ? |
eddycharly
changed the title
|
@sergenyalcin I'm going to merge this and do follow ups. Thanks for initiating the changes! |
|
/cherry-pick release-0.2 |
eddycharly
previously approved these changes
Sep 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1913 +/- ##
==========================================
- Coverage 70.01% 69.96% -0.06%
==========================================
Files 134 134
Lines 5489 5493 +4
==========================================
Hits 3843 3843
- Misses 1332 1334 +2
- Partials 314 316 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
eddycharly
approved these changes
Sep 6, 2024
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
…e parametrize the working directory (#1913) * Add workDir API to the script and command operation APIs to make parametrize the working directory Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com> * update codegen Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> --------- Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
eddycharly
added a commit
that referenced
this pull request
Sep 6, 2024
…e parametrize the working directory (#1913) (#1919) * Add workDir API to the script and command operation APIs to make parametrize the working directory * update codegen --------- Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com> Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com> Co-authored-by: Sergen Yalçın <44261342+sergenyalcin@users.noreply.github.com> Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The working directory for the script and command operations is hard-coded for the test directory. For some scripts it can affect the logic of some commands like cp. This is directly affects the end users of uptest after kuttl to chainsaw migration.
This PR adds
workDirAPI to the script and command operation APIs to make parametrize the working directory.Related issue
Fixes #1912
Proposed Changes
Checklist
Further Comments