Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make wait for jsonpath value optional #1887

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: make wait for jsonpath value optional #1887

merged 1 commit into from
Aug 26, 2024
+160 −108

Conversation

eddycharly
Copy link
Member

@eddycharly eddycharly commented Aug 26, 2024 •
edited
Loading

Explanation

Make wait for jsonpath value optional.

Fixes #1885

@eddycharly eddycharly requested a review from a team as a code owner August 26, 2024 22:17
@eddycharly eddycharly added this to the v0.2.9 milestone Aug 26, 2024
@eddycharly eddycharly mentioned this pull request Aug 26, 2024
Closed
1 task
@codecov Codecov
Copy link

codecov bot commented Aug 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 70.01%. Comparing base (7093e0c) to head (594eb63).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
pkg/engine/kubectl/wait.go 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1887      +/-   ##
==========================================
+ Coverage   70.00%   70.01%   +0.01%     
==========================================
  Files         134      134              
  Lines        5487     5490       +3     
==========================================
+ Hits         3841     3844       +3     
  Misses       1332     1332              
  Partials      314      314

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddycharly
fix: make wait for jsonpath value optional

Verified

This commit was signed with the committer’s verified signature.
crazy-max CrazyMax
GPG key ID: ADE44D8C9D44FBE4
Verified
Learn about vigilant mode
Loading
Loading status checks…
594eb63 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly eddycharly force-pushed the fix-wait-jsonpath-value branch from e7d669a to 594eb63 Compare August 26, 2024 22:35
@eddycharly
Copy link
Member Author

/cherry-pick release-0.2

@eddycharly eddycharly merged commit c638f64 into kyverno:main Aug 26, 2024
13 of 14 checks passed
@eddycharly eddycharly deleted the fix-wait-jsonpath-value branch August 26, 2024 22:46
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Aug 26, 2024
@eddycharly
fix: make wait for jsonpath value optional (#1887)

Verified

This commit was signed with the committer’s verified signature.
crazy-max CrazyMax
GPG key ID: ADE44D8C9D44FBE4
Verified
Learn about vigilant mode
Loading
Loading status checks…
64d8911 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Aug 26, 2024
Merged
eddycharly added a commit that referenced this pull request Aug 26, 2024
@gcp-cherry-pick-bot @eddycharly
fix: make wait for jsonpath value optional (#1887) (#1888)
Loading
Loading status checks…
3085705 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cherry-pick completed cherry-pick required release notes completed release notes required
Projects
None yet
Milestone
v0.2.9
Development

Successfully merging this pull request may close these issues.

[Feature] value for wait should be optional
1 participant
@eddycharly