Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add type for string expressions #1837

Merged
merged 1 commit into from
Aug 9, 2024
Merged

feat: add type for string expressions #1837

merged 1 commit into from
Aug 9, 2024
+34 −19

Conversation

eddycharly
Copy link
Member

Explanation

Add type for string expressions.

@eddycharly eddycharly added this to the v0.2.9 milestone Aug 8, 2024
@eddycharly
feat: add type for string expressions
Loading
Loading status checks…
047fa10 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@eddycharly
Copy link
Member Author

/cherry-pick release-0.2

@eddycharly eddycharly marked this pull request as ready for review August 9, 2024 09:10
@eddycharly eddycharly requested a review from a team as a code owner August 9, 2024 09:10
@codecov Codecov
Copy link

codecov bot commented Aug 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 70.30%. Comparing base (556385b) to head (047fa10).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
pkg/commands/migrate/kuttl/tests/command.go 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1837   +/-   ##
=======================================
  Coverage   70.30%   70.30%           
=======================================
  Files         133      133           
  Lines        5456     5456           
=======================================
  Hits         3836     3836           
  Misses       1308     1308           
  Partials      312      312

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddycharly eddycharly merged commit 8e36f27 into kyverno:main Aug 9, 2024
13 of 14 checks passed
@eddycharly eddycharly deleted the expressions-1 branch August 9, 2024 09:32
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Aug 9, 2024
@eddycharly
feat: add type for string expressions (#1837)
Loading
Loading status checks…
b7d706d 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Aug 9, 2024
Merged
eddycharly added a commit that referenced this pull request Aug 9, 2024
@gcp-cherry-pick-bot @eddycharly
feat: add type for string expressions (#1837) (#1838)
Loading
Loading status checks…
df3a774 
Signed-off-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Co-authored-by: Charles-Edouard Brétéché <charles.edouard@nirmata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cherry-pick completed cherry-pick required release notes completed release notes required
Projects
None yet
Milestone
v0.2.9
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@eddycharly