fix!: TimePicker/MonthPickerにtypeを指定できないようにする #5051
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
zoshigayan
changed the title
zoshigayan
requested review from
Qs-F and
masa0527
and removed request for
a team
|
ありがとうございます！！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
TimePicker/MonthPickerはinput要素に付与可能なすべての属性をpropsとして受け取ります<TimePicker type="date" />といった意図のわからない指定が可能になっていましたtype=timeが勝つので当該指定をしても挙動は変わりませんTimePickerは既にコンポーネントとして提供されているため一応BREAKING CHANGEという扱いにしています変更内容
PickerPropsからtypeを除外しました確認方法
TimePicker/MonthPickerにtype属性を指定すると型検査でエラーとなること