fix: Buttonをloading状態に切り替えるとフォーカスが外れてしまう問題の修正 #4684
Merged
+31
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misako0927
changed the title
misako0927
requested review from
Tokky0425 and
atzzCokeK
and removed request for
a team
s-sasaki-0529
approved these changes
Jun 14, 2024
uknmr
requested changes
Jun 25, 2024
Comment on lines
201
to
202
| 'aria-disabled:forced-colors:shr-border-[GrayText]', | ||
| 'aria-disabled:forced-colors:shr-text-[GrayText]', |
There was a problem hiding this comment.
いずれの variants でも共通のスタイルのため、compoundSlots に書く必要はなさそうに見えました。意図的でなければ default に移動しても良さそうです。
また、なぜ必要なスタイルなのかコードからは読み取りづらいので、コメントの追記をお願いします!（UA の disabled ではないから強制カラーモードの時に色が変わらない?
uknmr
approved these changes
Jul 1, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related URL
https://smarthr.atlassian.net/browse/SHRUI-952
Overview
aria-disabledを使用することでフォーカスが外れないようにした
What I did
Capture