feat: Headerに言語切替UIを実装 #4613
Merged
feat: Headerに言語切替UIを実装 #4613
+333
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masuP9
force-pushed
the
feat/language-switcher
branch
10 times, most recently
from
be931e7 to
5684a10
Compare
masuP9
commented
May 8, 2024
Comment on lines
+73
to
+76
| const currentLang = useMemo( | ||
| () => locale || defaultLocale || Object.keys(localeMap)[0], | ||
| [locale, defaultLocale, localeMap], | ||
| ) |
There was a problem hiding this comment.
LanguageSwitcher では、選択された言語を状態として持たず、Propsから受け取るのみ。
masuP9
commented
May 8, 2024
| return ( | ||
| <Dropdown {...props}> | ||
| <DropdownTrigger>{narrow ? NarrowTrigger : Trigger}</DropdownTrigger> | ||
| <DropdownContent onKeyDown={handleKeyDown} role="presentation"> |
There was a problem hiding this comment.
<DropdownContent> 内のキーボード操作をキャプチャするために DropdownContent に onKeyDown を設定。ESLintのエラー回避のために role="presentation" を付与
masuP9
force-pushed
the
feat/language-switcher
branch
2 times, most recently
from
75cc625 to
3e1730b
Compare
masuP9
requested review from
oti,
AtsushiM,
nabeliwo,
k-shirahama,
TakahiroHimi and
ntfd0
and removed request for
a team
masuP9
force-pushed
the
feat/language-switcher
branch
2 times, most recently
from
1746ea7 to
1bd4c7b
Compare
nabeliwo
approved these changes
May 8, 2024
|
LGTM！ |
k-shirahama
approved these changes
May 9, 2024
masuP9
force-pushed
the
feat/language-switcher
branch
from
1bd4c7b to
7c64a3b
Compare
masuP9
force-pushed
the
feat/language-switcher
branch
from
7c64a3b to
967a227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related URL
Overview
What I did
<LanguageSwitcher>コンポーネントを実装<Header>内での利用を想定しているため、/Header配下に作成しているが、単独でも利用できるように、単独でも export しているinvertのスタイルを実装narrowのスタイルを実装Capture
Storybook: Navigation（ナビゲーション） / Header / LanguageSwitcher - Docs ⋅ Storybook