fix tinygo build caused by go toolchain #109
Merged
+47
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest version of Go introduces the concept of toolchain [1]. This brings a new keyword inside of `go.mod`. This keyword can be understood using Go 1.21 or later. Even though our Go policies are built with TinyGo, TinyGo requires the official Go compiler to perform some tasks. Because of that, we have to ensure the latest stable release of the Go compiler is installed inside of the build environment. We cannot rely on what is shipped out of the box with the GH runner image. [1] https://go.dev/blog/toolchain Signed-off-by: Flavio Castelli <fcastelli@suse.com>
``` sed --in-place 's/3\.1\.15/3\.1\.16/' $(find . -maxdepth 3 -name "*.yml") ```` Signed-off-by: Flavio Castelli <fcastelli@suse.com>
viccuad
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest version of Go introduces the concept of toolchain.
This brings a new keyword inside of
go.mod. This keyword can be understood using Go 1.21 or later.Even though our Go policies are built with TinyGo, TinyGo requires the official Go compiler to perform some tasks.
Because of that, we have to ensure the latest stable release of the Go compiler is installed inside of the build environment. We cannot rely on what is shipped out of the box with the GH runner image.
This PR contains two commits:
Once merged, I'll create the
v3.1.16tag.