Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build k8s-ci-builder and k8s-cloud-bulider with Go 1.22.2 #3555

Merged
merged 1 commit into from Apr 5, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Apr 5, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Build k8s-ci-builder and k8s-cloud-bulider with Go 1.22.2

/assign @saschagrunert @ameukam @Verolop
cc @kubernetes/release-engineering

Which issue(s) this PR fixes:

xref #3529

Does this PR introduce a user-facing change?

Build k8s-ci-builder and k8s-cloud-bulider with Go 1.22.2

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 5, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 5, 2024
@ameukam
Copy link
Member

ameukam commented Apr 5, 2024

/retest

@xmudrii
Copy link
Member

xmudrii commented Apr 5, 2024

Looks like we're using too old Go version in the builder:

#6 [builder 4/4] RUN ./compile-release-tools
#6 0.076 Setting up environment...
#6 0.076 Compiling default release tools...
#6 0.078 fatal: not a git repository (or any of the parent directories): .git
#6 0.084 go: go.mod requires go >= 1.22 (running go 1.21.8; GOTOOLCHAIN=local)

@cpanato
Copy link
Member Author

cpanato commented Apr 5, 2024

Looks like we're using too old Go version in the builder:

#6 [builder 4/4] RUN ./compile-release-tools
#6 0.076 Setting up environment...
#6 0.076 Compiling default release tools...
#6 0.078 fatal: not a git repository (or any of the parent directories): .git
#6 0.084 go: go.mod requires go >= 1.22 (running go 1.21.8; GOTOOLCHAIN=local)

but that failed for the 1.28 go ( https://console.cloud.google.com/cloud-build/builds;region=global/970bbfe0-4d71-44bc-8cd7-b5ef34381264?project=k8s-staging-releng-test)

@cpanato
Copy link
Member Author

cpanato commented Apr 5, 2024

we need to update the go.mod in k/release

Signed-off-by: cpanato <ctadeu@gmail.com>
@dims
Copy link
Member

dims commented Apr 5, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@cpanato
Copy link
Member Author

cpanato commented Apr 5, 2024

@dims PTAL

@dims
Copy link
Member

dims commented Apr 5, 2024

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9830c43 into kubernetes:master Apr 5, 2024
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Apr 5, 2024
@cpanato cpanato deleted the builder-1.22 branch April 5, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants