-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move selector immutability check to validation after v1beta1 retires #50791
Comments
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
the beta types have not been served since 1.16, so this can be done now. relevant spots to update are in https://grep.app/search?q=TODO%28%2350791%29&filter[repo][0]=kubernetes/kubernetes |
/assign |
/unassign |
@crimsonfaith91 is this issue still up for grabs? If so then as a new contributor I would like to take this up. |
I had a PR to resolve it but it never got reviewed. If you do grab it:
|
Thanks a lot @yardenshoham! I did go through your PR and understand the basics of what the issue entails. Also I still can't believe that your PR went unreviewed for an entire year! |
/assign |
/assign |
is this issue still open ? |
/assign |
The check for selector immutability is located at
PrepareForUpdate
functions ofdeploymentStrategy
,rsStrategy
anddaemonSetStrategy
. We are not able to have the check at validation before v1beta1 API version retires due to breaking change to some tests (discussed in this closed PR). Once v1beta1 retires, we should move the check to validation.The text was updated successfully, but these errors were encountered: