Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StructuredAuthorizationConfig] benchmark for match expressions #121659

Closed
ritazh opened this issue Oct 31, 2023 · 1 comment · Fixed by #121822
Closed

[StructuredAuthorizationConfig] benchmark for match expressions #121659

ritazh opened this issue Oct 31, 2023 · 1 comment · Fixed by #121822
Labels
sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ritazh
Copy link
Member

ritazh commented Oct 31, 2023

In a follow-up (ideally before test freeze), it would also be good to add a benchmark around compilation and evaluation in a follow-up so we can quantify the cost of putting match expressions of a few different levels of complexity in a webhook and make sure our evaluation is as cheap / fast as we think it is.

Originally posted by @liggitt in #121223 (comment)
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 31, 2023
@ritazh
Copy link
Member Author

ritazh commented Oct 31, 2023

/triage accepted
/sig auth

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 31, 2023
@ritazh ritazh mentioned this issue Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/auth Categorizes an issue or PR as relevant to SIG Auth. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
Structured Authz Enhancement
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[StructuredAuthz] Webhookauthz benchmark ritazh/kubernetes
2 participants
@ritazh @k8s-ci-robot