Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release when querying github is NOT newest version #119472

Closed
erstcloudbot opened this issue Jul 20, 2023 · 9 comments
Closed

Latest release when querying github is NOT newest version #119472

erstcloudbot opened this issue Jul 20, 2023 · 9 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/release Categorizes an issue or PR as relevant to SIG Release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@erstcloudbot
Copy link

What happened?

Asking github for the latest releases gives version 1.24.16 when 1.27.4 is available.

What did you expect to happen?

Get 1.27.4

How can we reproduce it (as minimally and precisely as possible)?

curl https://api.github.com/repos/kubernetes/kubernetes/releases/latest

Anything else we need to know?

No response

Kubernetes version

$ kubectl version
# paste output here

Cloud provider

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

@erstcloudbot erstcloudbot added the kind/bug Categorizes issue or PR as related to a bug. label Jul 20, 2023
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saschagrunert
Copy link
Member

saschagrunert commented Jul 20, 2023

/sig release

Right now it depends on the order we release the patches, so technically it is the latest release, but not logically.

We could fix that by running krel release for the latest release branch at the end of the process or by adding a technical solution. Thoughts on that @kubernetes/release-managers ?

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 20, 2023
@saschagrunert saschagrunert added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 20, 2023
@xmudrii
Copy link
Member

xmudrii commented Jul 20, 2023

We could fix that by running krel release for the latest release branch at the end of the process or by adding a technical solution.

GitHub supports marking a release as the latest. We need to check if we can do that automatically via krel

@xmudrii
Copy link
Member

xmudrii commented Jul 20, 2023

I'll be taking care of this
/assign

@xmudrii
Copy link
Member

xmudrii commented Dec 11, 2023

My colleague @embik would like to give this a try, I'm assigning this issue to him, but he's not an org member yet so this might fail
/assign @embik

@k8s-ci-robot
Copy link
Contributor

@xmudrii: GitHub didn't allow me to assign the following users: embik.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

My colleague @embik would like to give this a try, I'm assigning this issue to him, but he's not an org member yet so this might fail
/assign @embik

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member

xmudrii commented Apr 10, 2024

A fix for this issue (kubernetes/release#3559) has been merged. However, we need a new krel release for this fix to be in effect, so I'll keep the issue open until then.

@xmudrii
Copy link
Member

xmudrii commented May 15, 2024

This should be fixed now, thanks a lot @embik for taking care of this!!
/close

@k8s-ci-robot
Copy link
Contributor

@xmudrii: Closing this issue.

In response to this:

This should be fixed now, thanks a lot @embik for taking care of this!!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/release Categorizes an issue or PR as relevant to SIG Release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants