fsnotify/fsnotify needs help

[dims]

Please see fsnotify/fsnotify#413 Looks like there is a new maintainer https://github.com/fsnotify/fsnotify/commits/main but we need to keep an eye on the project.

Also we are using version v1.4.9 and latest is v1.5.4, so we need to update to newer version at least.

Differences are fsnotify/fsnotify@v1.4.9...v1.5.4

/area code-organization

[k8s-ci-robot]

@dims: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dims]

cc @pacoxu perhaps?

[pacoxu]

https://github.com/fsnotify/fsnotify/blob/main/CHANGELOG.md#154---2022-04-25
Only several bugs were fixed from 1.5.0 to 1.5.4.

https://github.com/fsnotify/fsnotify/blob/main/CHANGELOG.md#unreleased
More PRs were merged after 1.5.4 which is unreleased yet.

Changes focus on the windows side(8 PRs since August). Other changes are the golang version, x/sys update, and some bug fixes.

[dims]

/sig architecture

[pacoxu]

Where do we use fsnotify?

1. kubelet: manifests for static pods; log related; plugin dir; flex volume
2. kube-proxy: config file
3. apiserver: dynamic ca

v1.6.0 was released. https://github.com/fsnotify/fsnotify/blob/main/CHANGELOG.md#160---2022-10-13

• focus on windows/kqueue bugfixes. For Linux change, see inotify.

for windows and kqueue(for freebsd || openbsd || netbsd || dragonfly || darwin) changes.

• kqueue: Make watcher.Close() O(n) instead of O(n^2) fsnotify/fsnotify#233 （ better performance: interested to me）

[pacoxu]

Link some related issues:

• kubectl logs with the --follow args, the log loops indefinitely #103500 which is https://github.com/fsnotify/fsnotify/issues/421： ChMod event when renaming.
• prevent DDOS registering attack from plugins at pluginwatcher #67517 prevent DDOS in pluginwatcher
• why Inotify isn't switched to fsnotify? #73626 (closed as cadvisor switched back for flakes?)

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue as fresh with /remove-lifecycle rotten
• Close this issue with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue with /reopen
• Mark this issue as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.