-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubectl apply: prune should ignore no-namespaced resource if -n is not empty #110905
Comments
I prefer to think this is a bug of kubectl. /kind bug |
Hi @pacoxu I was looking at the test cases for prune inside Should we fix the test case as well? I have tried to setup the |
@harry1064 We may add some in separate pr. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
/triage accepted |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
May I take this up? |
/assign |
Hey @m-Bilal , If you are working on this, you can take that forward and assign yourself. I will check out some other issues. |
@manav014 sorry I should have been clearer. I haven't started yet. So if you have started, that's fine, I can look into another one. If not, then I'm happy to take this up 😄 |
@m-Bilal I started with that. I will share what am I planning and other research, we can collaborate on this. You can help me with optimizations and feedback. If that sounds good to you. |
#110907 was merged in v1.26
kubernetes/staging/src/k8s.io/kubectl/pkg/util/prune/prune.go Lines 66 to 73 in 3ce7cdd
|
/remove-lifecycle stale |
This can be done in v1.29 release cycle. The TODO can be fixed. kubernetes/staging/src/k8s.io/kubectl/pkg/util/prune/prune.go Lines 68 to 72 in d25c0a1
|
/help |
@pacoxu: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'd like to work on this issue |
Hi @pacoxu I can't reproduce this. |
Can you please elaborate more on that. What is the current behaviour and what is the expected behaviour of |
I would love to work on this issue. (This is my first issue in this repository) |
I edited the description. Can you try again? |
I mean that
|
See #119687 (comment). There is a bug in previous implementation with my PR #110907. |
Hi all, |
This is a warning message, not an error message. |
kubectl apply
with below yaml and follow below prune command.seems I have the same problem. save this to a file named
a.yaml
And run
kubectl apply --prune --dry-run=client --all -n sandbox -f a.yaml
, the resultsI have no idea why it want to prune the
namespace/cattle-system
.Originally posted by @wd in #66430 (comment)
The text was updated successfully, but these errors were encountered: