forked from golang/glog
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InitFlags data race #348
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Comments
Lines 418 to 438 in 02fe323
shouldn't that function be locked?
|
That wouldn't work, some flags are implemented so that they use atomic read/writes. I have a different solution, but GitHub currently doesn't let me create the PR. |
/assign |
See #349 |
pohly
added a commit
to pohly/kubernetes
that referenced
this issue
Sep 9, 2022
The fix for kubernetes/klog#348 is required before kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race.
k8s-publishing-bot
pushed a commit
to kubernetes/code-generator
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/apimachinery
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/api
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/client-go
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/component-base
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/component-helpers
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/apiserver
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/kube-aggregator
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/sample-apiserver
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/sample-controller
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/apiextensions-apiserver
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/metrics
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/cli-runtime
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/sample-cli-plugin
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/kube-proxy
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/kubelet
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/kube-scheduler
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/controller-manager
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/cloud-provider
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/kube-controller-manager
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/cluster-bootstrap
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/csi-translation-lib
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/mount-utils
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/legacy-cloud-providers
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/kubectl
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
k8s-publishing-bot
pushed a commit
to kubernetes/pod-security-admission
that referenced
this issue
Sep 10, 2022
The fix for kubernetes/klog#348 is required before kubernetes/kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race. Kubernetes-commit: 60d92dd96a4ba3873dd9e061c3e332c16c213e30
danielye11
pushed a commit
to danielye11/kubernetes
that referenced
this issue
Sep 21, 2022
The fix for kubernetes/klog#348 is required before kubernetes#111998 can be merged because the way how a unit test in that PR uses klog triggers the data race.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
/kind bug
What steps did you take and what happened:
When I wrote some (unrelated) unit test that calls
klog.InitFlags
with a new flag set while some other goroutine was calling klog for logging,go test -race
reported a data race:What did you expect to happen:
No data race.
Anything else you would like to add:
I believe the reason is that calls like
flagset.BoolVar(&logging.toStderr, "logtostderr", logging.toStderr, "log to standard error instead of files")
(the line atklog.go:428
) write the default value.InitFlags
shouldn't do that.The text was updated successfully, but these errors were encountered: