Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates go, golangci-lint, cosign #93

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Updates go, golangci-lint, cosign #93

merged 3 commits into from
Sep 1, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Sep 1, 2023

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

  • set minimum go version to 1.20
  • bump cosign to v2.2.0
  • bump golangci-lint to v1.54.2

/hold for test-infra job change to test with go1.21

/assign @saschagrunert @xmudrii @Verolop
cc @kubernetes-sigs/release-engineering

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- set minimum go version to 1.20
- bump cosign to v2.2.0
- bump golangci-lint to v1.54.2

@cpanato
set minimum go version to 1.20
b65252c 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
bump cosign to v2.2.0
86492f0 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
bump golangci-lint to v1.54.2
19113e6 
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2023
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 1, 2023
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 1, 2023
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Sep 1, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 1, 2023
@cpanato cpanato mentioned this pull request Sep 1, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Sep 1, 2023

/test all

@cpanato
Copy link
Member Author

cpanato commented Sep 1, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit ff2d69b into kubernetes-sigs:main Sep 1, 2023
4 checks passed
@cpanato cpanato deleted the updates branch September 1, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@palnabarun palnabarun Awaiting requested review from palnabarun

@Verolop Verolop Awaiting requested review from Verolop

Assignees

@saschagrunert saschagrunert

@Verolop Verolop

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cpanato @k8s-ci-robot @saschagrunert @Verolop @xmudrii