Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update deprecated doc refs #5324

Merged
merged 1 commit into from Oct 18, 2023

Conversation

charles-chenzz
Copy link
Member

while I was reading code in cmd/pluginator I found out an deprecated doc ref. I think it's better to keep it update to date.
/cc @annasong20

image

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 9, 2023
@bugoverdose
Copy link
Member

Can you check more use cases like this? It would be really helpful.
image

@charles-chenzz
Copy link
Member Author

Can you check more use cases like this? It would be really helpful. image

sure, I can. but do we want to update in this PR as well? I prefer to open an issue and track it by multiple PR

@bugoverdose
Copy link
Member

bugoverdose commented Sep 21, 2023

sure, I can. but do we want to update in this PR as well? I prefer to open an issue and track it by multiple PR

Using multiple PRs could be a way, but I personally don't think that it's necessary and I think the reviewing process would be much faster if we use this one PR.

It's up to you. If you want to stop here in this PR, it's a LGTM for me.

@charles-chenzz
Copy link
Member Author

sure, I can. but do we want to update in this PR as well? I prefer to open an issue and track it by multiple PR

Using multiple PRs could be a way, but I personally don't think that it's necessary and I think the reviewing process would be much faster if we use this one PR.

It's up to you. If you want to stop here in this PR, it's a LGTM for me.

I would check few more places to see if there's any mismatch link. It might take some time but we'll see.

@charles-chenzz
Copy link
Member Author

I couldn't find more deprecated doc refs currently, so I think it's time to move this PR forward. wdyt? @bugoverdose

@charles-chenzz charles-chenzz changed the title update deprecated doc refs in cmd/pluginator update deprecated doc refs Oct 11, 2023
Copy link
Member

@bugoverdose bugoverdose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please feel free to make other PRs on documentations whenever you want. We really could use a hand.

@bugoverdose
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2023
@charles-chenzz
Copy link
Member Author

@annasong20 would you mind approving this?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bugoverdose, charles-chenzz, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit bde28b1 into kubernetes-sigs:master Oct 18, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants