New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update deprecated doc refs #5324
update deprecated doc refs #5324
Conversation
Using multiple PRs could be a way, but I personally don't think that it's necessary and I think the reviewing process would be much faster if we use this one PR. It's up to you. If you want to stop here in this PR, it's a LGTM for me. |
I would check few more places to see if there's any mismatch link. It might take some time but we'll see. |
52dfa1f
to
944c72a
Compare
I couldn't find more deprecated doc refs currently, so I think it's time to move this PR forward. wdyt? @bugoverdose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please feel free to make other PRs on documentations whenever you want. We really could use a hand.
/lgtm |
@annasong20 would you mind approving this? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bugoverdose, charles-chenzz, natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
while I was reading code in cmd/pluginator I found out an deprecated doc ref. I think it's better to keep it update to date.
/cc @annasong20