-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replacements: fix issue with create: true
option when there is an existing field
#4667
replacements: fix issue with create: true
option when there is an existing field
#4667
Conversation
@natasha41575: This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
51f9a82
to
ff1c2a2
Compare
/label tide/merge-method-squash |
PR looks good and the logic is straight forward to me. Defer to @KnVerey to approve. |
Hi Could you check it? |
…ith an already existing field
ff1c2a2
to
bc6f652
Compare
bc6f652
to
a1876b0
Compare
a1876b0
to
303e889
Compare
303e889
to
b0662b5
Compare
12cae32
to
38a975b
Compare
38a975b
to
fe85527
Compare
9ae74b5
to
27028da
Compare
/lgtm |
First commit demonstrates the bug, second one fixes it. Likely caused by #4424. Follow up to this review comment #4577 (comment).
LookupCreate
seems to do weird things if the field already exists. So the logic here is just: if the field already exists, don't useLookupCreate
./cc @KnVerey @yuwenma