Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missmatch compatibilities with sigs.k8s.io/controller-runtime #1125

Closed
raviand opened this issue Sep 15, 2023 · 2 comments
Closed

Missmatch compatibilities with sigs.k8s.io/controller-runtime #1125

raviand opened this issue Sep 15, 2023 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@raviand
Copy link

raviand commented Sep 15, 2023

I'm trying to update all the versions in a controller and I found a compatibility issue between the latest stable version of this repo
sigs.k8s.io/kueue v0.4.1
vs the latest stable version of the controller-runtime
sigs.k8s.io/controller-runtime v016.1

What happened:
running the controller's test

rvidela@LG-W-RVID402:/mnt/c/Users/rvidela/GolangProject/src/microservice-controller$ go test ./... -v
# sigs.k8s.io/kueue/pkg/config
/home/rvidela/go/pkg/mod/sigs.k8s.io/kueue@v0.4.1/pkg/config/config.go:51:7: o.MetricsBindAddress undefined (type *manager.Options has no field or method MetricsBindAddress)
/home/rvidela/go/pkg/mod/sigs.k8s.io/kueue@v0.4.1/pkg/config/config.go:52:5: o.MetricsBindAddress undefined (type *manager.Options has no field or method MetricsBindAddress)

What you expected to happen:

all tests pass without failing

How to reproduce it (as minimally and precisely as possible):

run go get -u in a kubebuilder controller repo
Check versions, should see this in go.mod
sigs.k8s.io/controller-runtime v016.1
sigs.k8s.io/kueue v0.4.1

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version): local test
  • Kueue version (use git describe --tags --dirty --always): v0.4.1
  • Cloud provider or hardware configuration: wsl linux system on windows
  • OS (e.g: cat /etc/os-release): Ubuntu 20.04.3 LTS
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
    /bug
@raviand raviand added the kind/bug Categorizes issue or PR as related to a bug. label Sep 15, 2023
@tenzen-y
Copy link
Member

This is not a bug. That error is caused by the breaking change in the controller-runtime v0.16.0.
So, if you use kueue as a library, you must use the controller-runtime v0.15.x.

https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0

However, we will upgrade the controller-runtime version to v0.16.x in a few days, as I mentioned in #1054 (comment).

/close

@k8s-ci-robot
Copy link
Contributor

@tenzen-y: Closing this issue.

In response to this:

This is not a bug. That error is caused by the breaking change in the controller-runtime v0.16.0.
So, if you use kueue as a library, you must use the controller-runtime v0.15.x.

https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0

However, we will upgrade the controller-runtime version to v0.16.x in a few days, as I mentioned in #1054 (comment).

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants