[release-0.18] 🐛 correct kind source type #2809
Merged
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverse the nil check in the String function of the internal Kind source to print the type when known. Fixes: 2add01e ("Event, source, handler, predicates: Use generics") Signed-off-by: Terin Stock <terinjokes@gmail.com>
k8s-ci-robot
added
the
cncf-cla: yes
alvaroaleman
approved these changes
May 1, 2024
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 0344b00f9d610f78ce462cb89b240e04ec0e5a17
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/S
renovate bot
added a commit
to registry-operator/registry-operator
that referenced
this pull request
May 2, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [sigs.k8s.io/controller-runtime](https://togithub.com/kubernetes-sigs/controller-runtime) | `v0.18.0` -> `v0.18.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)</summary> ### [`v0.18.1`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.1) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.18.0...v0.18.1) #### What's Changed - \[release-0.18] 🐛 Cache: Fix label defaulting of byObject when namespaces are configured by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [kubernetes-sigs/controller-runtime#2808 - \[release-0.18] 🐛 correct kind source type by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [kubernetes-sigs/controller-runtime#2809 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.18.0...v0.18.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/registry-operator/registry-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMzEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJhcmVhL2RlcGVuZGVuY3kiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
added a commit
to aenix-io/etcd-operator
that referenced
this pull request
May 4, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | [actions/setup-go](https://togithub.com/actions/setup-go) | action | patch | `v5.0.0` -> `v5.0.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [github.com/onsi/gomega](https://togithub.com/onsi/gomega) | require | patch | `v1.33.0` -> `v1.33.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [golangci/golangci-lint](https://togithub.com/golangci/golangci-lint) | | minor | `v1.57.2` -> `v1.58.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [hugo-extended](https://togithub.com/jakejarvis/hugo-extended) | devDependencies | patch | [`0.125.2` -> `0.125.4`](https://renovatebot.com/diffs/npm/hugo-extended/0.125.2/0.125.4) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [k8s.io/utils](https://togithub.com/kubernetes/utils) | require | patch | `v0.0.0-20240423183400-0849a56e8f22` -> `v0.0.0-20240502163921-fe8a2dddb1d0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [losisin/helm-values-schema-json](https://togithub.com/losisin/helm-values-schema-json) | | minor | `v1.2.4` -> `v1.3.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [sigs.k8s.io/controller-runtime](https://togithub.com/kubernetes-sigs/controller-runtime) | require | patch | `v0.18.0` -> `v0.18.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>actions/setup-go (actions/setup-go)</summary> ### [`v5.0.1`](https://togithub.com/actions/setup-go/releases/tag/v5.0.1) [Compare Source](https://togithub.com/actions/setup-go/compare/v5.0.0...v5.0.1) #### What's Changed - Bump undici from 5.28.2 to 5.28.3 and dependencies upgrade by [@​dependabot](https://togithub.com/dependabot) , [@​HarithaVattikuti](https://togithub.com/HarithaVattikuti) in [actions/setup-go#465 - Update documentation with latest V5 release notes by [@​ab](https://togithub.com/ab) in [actions/setup-go#459 - Update version documentation by [@​178inaba](https://togithub.com/178inaba) in [actions/setup-go#458 - Documentation update of `actions/setup-go` to v5 by [@​chenrui333](https://togithub.com/chenrui333) in [actions/setup-go#449 #### New Contributors - [@​ab](https://togithub.com/ab) made their first contribution in [actions/setup-go#459 **Full Changelog**: actions/setup-go@v5.0.0...v5.0.1 </details> <details> <summary>onsi/gomega (github.com/onsi/gomega)</summary> ### [`v1.33.1`](https://togithub.com/onsi/gomega/releases/tag/v1.33.1) [Compare Source](https://togithub.com/onsi/gomega/compare/v1.33.0...v1.33.1) ##### 1.33.1 ##### Fixes - fix confusing eventually docs \[[`3a66379`](https://togithub.com/onsi/gomega/commit/3a66379)] ##### Maintenance - Bump github.com/onsi/ginkgo/v2 from 2.17.1 to 2.17.2 \[[`e9bc35a`](https://togithub.com/onsi/gomega/commit/e9bc35a)] </details> <details> <summary>golangci/golangci-lint (golangci/golangci-lint)</summary> ### [`v1.58.0`](https://togithub.com/golangci/golangci-lint/compare/v1.57.2...v1.58.0) [Compare Source](https://togithub.com/golangci/golangci-lint/compare/v1.57.2...v1.58.0) </details> <details> <summary>jakejarvis/hugo-extended (hugo-extended)</summary> ### [`v0.125.4`](https://togithub.com/jakejarvis/hugo-extended/compare/v0.125.3...v0.125.4) [Compare Source](https://togithub.com/jakejarvis/hugo-extended/compare/v0.125.3...v0.125.4) ### [`v0.125.3`](https://togithub.com/jakejarvis/hugo-extended/compare/v0.125.2...v0.125.3) [Compare Source](https://togithub.com/jakejarvis/hugo-extended/compare/v0.125.2...v0.125.3) </details> <details> <summary>losisin/helm-values-schema-json (losisin/helm-values-schema-json)</summary> ### [`v1.3.0`](https://togithub.com/losisin/helm-values-schema-json/releases/tag/v1.3.0) [Compare Source](https://togithub.com/losisin/helm-values-schema-json/compare/v1.2.4...v1.3.0) #### Changelog - [`53d2c61`](https://togithub.com/losisin/helm-values-schema-json/commit/53d2c61) Bump azure/setup-helm from 4.1.0 to 4.2.0 - [`b453151`](https://togithub.com/losisin/helm-values-schema-json/commit/b453151) Bump golangci/golangci-lint-action from 4 to 5 - [`a4a9822`](https://togithub.com/losisin/helm-values-schema-json/commit/a4a9822) Merge pull request [#​59](https://togithub.com/losisin/helm-values-schema-json/issues/59) from losisin/dependabot/github_actions/azure/setup-helm-4.2.0 - [`f04bbe4`](https://togithub.com/losisin/helm-values-schema-json/commit/f04bbe4) Merge pull request [#​60](https://togithub.com/losisin/helm-values-schema-json/issues/60) from losisin/dependabot/github_actions/golangci/golangci-lint-action-5 - [`f87b874`](https://togithub.com/losisin/helm-values-schema-json/commit/f87b874) Merge pull request [#​62](https://togithub.com/losisin/helm-values-schema-json/issues/62) from losisin/feature/indent-cli-option - [`cb41def`](https://togithub.com/losisin/helm-values-schema-json/commit/cb41def) add indent cli option - [`2a02a16`](https://togithub.com/losisin/helm-values-schema-json/commit/2a02a16) add step to check code in workflow - [`613cb3a`](https://togithub.com/losisin/helm-values-schema-json/commit/613cb3a) update readme </details> <details> <summary>kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)</summary> ### [`v0.18.1`](https://togithub.com/kubernetes-sigs/controller-runtime/releases/tag/v0.18.1) [Compare Source](https://togithub.com/kubernetes-sigs/controller-runtime/compare/v0.18.0...v0.18.1) #### What's Changed - \[release-0.18] 🐛 Cache: Fix label defaulting of byObject when namespaces are configured by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [kubernetes-sigs/controller-runtime#2808 - \[release-0.18] 🐛 correct kind source type by [@​k8s-infra-cherrypick-robot](https://togithub.com/k8s-infra-cherrypick-robot) in [kubernetes-sigs/controller-runtime#2809 **Full Changelog**: kubernetes-sigs/controller-runtime@v0.18.0...v0.18.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* * * * 6" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/aenix-io/etcd-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMzEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMzMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJvay10by10ZXN0Il19--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Hidden Marten <hiddenmarten@gmail.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2806
/assign alvaroaleman