Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Avoid dependency on apiserver/options if metrics/filters are used #2645

Merged
merged 1 commit into from Jan 10, 2024

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

This also avoids a dependency on component-base/metrics/prometheus/workqueue, which we really want to avoid as it initialized the workqueue metrics before our init.

 go mod why k8s.io/component-base/metrics/prometheus/workqueue
# k8s.io/component-base/metrics/prometheus/workqueue
sigs.k8s.io/cluster-api/util/flags
sigs.k8s.io/controller-runtime/pkg/metrics/filters
k8s.io/apiserver/pkg/server/options
k8s.io/apiserver/pkg/server
k8s.io/apiserver/pkg/endpoints/filters
k8s.io/component-base/metrics/prometheus/workqueue

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 10, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 10, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 10, 2024
@sbueringer sbueringer added this to the v0.17.x milestone Jan 10, 2024
@sbueringer
Copy link
Member Author

Re: apidiff. My guess is apidiff might has problems with generics

@sbueringer
Copy link
Member Author

Re: apidiff. My guess is apidiff might has problems with generics

^^ @joelanford just fyi

Signed-off-by: Stefan Büringer buringerst@vmware.com
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 10, 2024

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-controller-runtime-apidiff 5172a23 link false /test pull-controller-runtime-apidiff

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@inteon
Copy link
Member

inteon commented Jan 10, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8f8247f into kubernetes-sigs:main Jan 10, 2024
8 of 9 checks passed
@sbueringer sbueringer deleted the pr-avoid-deps branch January 10, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants