✨Add flowcontrol api v1 for Kubernetes v1.29.0 #2623
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/retest |
| @@ -1252,8 +1252,8 @@ func inTreeResourcesWithStatus() []schema.GroupVersionKind { | |||
|
|
|||
| {Group: "apiextensions.k8s.io", Version: "v1", Kind: "CustomResourceDefinition"}, | |||
|
|
|||
| {Group: "flowcontrol.apiserver.k8s.io", Version: "v1beta2", Kind: "FlowSchema"}, | |||
| {Group: "flowcontrol.apiserver.k8s.io", Version: "v1beta2", Kind: "PriorityLevelConfiguration"}, | |||
| {Group: "flowcontrol.apiserver.k8s.io", Version: "v1", Kind: "FlowSchema"}, | |||
There was a problem hiding this comment.
I think we should have both. This config is just for the status subresource. Most of our users will not be using kube 1.29 right away and so they might be forced to use the older version. I don't see a reason to break testing for that.
There was a problem hiding this comment.
That's fair, I'll update it with the v1beta2 as well.
Signed-off-by: Troy Connor <troy0820@users.noreply.github.com>
troy0820
force-pushed
the
troy0820/remove-flowcontrol-api
branch
from
c81e7d9
to
51d7681
Compare
troy0820
changed the title
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, troy0820 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thx! @troy0820 can you please update the PR description. It's just a bit misleading now :) |
Kubernetes released v1.29.0 and with that release was the deprecation and removal of flowcontrol v1beta2.
This PR adds to the fake client v1 of the flow control api as v1.29.0 is not serving v1beta2 anymore. To maintain backwards compatibility, we will keep v1beta2 but add v1.
inTreeResourcesWithStatus()function