🌱 envtest: improve process cleanup #2560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
alvaroaleman
approved these changes
Oct 23, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
vincepri
force-pushed
the
better-cleanup
branch
from
e03cc2a
to
b3737d7
Compare
k8s-ci-robot
removed
the
lgtm
vincepri
force-pushed
the
better-cleanup
branch
from
b3737d7
to
12375c4
Compare
When envtest creates new processes, it wasn't setting the process group to the parent, when the main process is killed or it panics, all the other processes are orphaned, and need to be killed separately. In addition, if for some reason we can't shutdown a process cleanly, we should try to SIGKILL before returning from Stop. Signed-off-by: Vince Prignano <vincepri@redhat.com>
vincepri
force-pushed
the
better-cleanup
branch
from
12375c4
to
b10b858
Compare
vincepri
commented
Oct 23, 2023
ncdc
reviewed
Oct 23, 2023
|
@alvaroaleman @ncdc ptal |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When envtest creates new processes, it wasn't setting the process group to the parent, when the main process is killed or it panics, all the other processes are orphaned, and need to be killed separately.
In addition, if for some reason we can't shutdown a process cleanly, we should try to SIGKILL before returning from Stop.
/assign @alvaroaleman