✨ Cache: Allow defining options that apply to all namespaces that themselves have no explicit config #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
troy0820
reviewed
Oct 8, 2023
pkg/cache/cache.go
Outdated
| @@ -172,6 +178,11 @@ type Options struct { | |||
| // the namespaces in here will be watched and it will by used to default | |||
| // ByObject.Namespaces for all objects if that is nil. | |||
| // | |||
| // It is possible to have specific Config for just some namespaces | |||
| // but cache all namespaces by using the AllNamespaces const as the map key. | |||
| // This wil then include all namespaces that do not have a more specific | |||
There was a problem hiding this comment.
nit
Suggested change
| // This wil then include all namespaces that do not have a more specific | |
| // This will then include all namespaces that do not have a more specific |
troy0820
reviewed
Oct 8, 2023
pkg/cache/cache.go
Outdated
| @@ -220,6 +231,11 @@ type ByObject struct { | |||
| // Settings in the map value that are unset will be defaulted. | |||
| // Use an empty value for the specific setting to prevent that. | |||
| // | |||
| // It is possible to have specific Config for just some namespaces | |||
| // but cache all namespaces by using the AllNamespaces const as the map key. | |||
| // This wil then include all namespaces that do not have a more specific | |||
There was a problem hiding this comment.
nit
Suggested change
| // This wil then include all namespaces that do not have a more specific | |
| // This will then include all namespaces that do not have a more specific |
…mselves have no explicit config This change allows to define a cache selector config that applies to all namespaces that themselves do not have an explicit config. An example would be "Cache all namespaces without selector, except for namespace foo, there use labelSelector bar=baz". More as a side effect than intentionally, this also makes it valid to use the empty string as a key in the `Namespaces` and `byObject.Namespaces` config of the cache. This is very useful to for example have a `namespace` CLI flag that might be empty. This change is the last missing bit to finish the implementation of the [cache options design doc](./designs/cache_options.md).
alvaroaleman
force-pushed
the
allow-all-but
branch
from
47ae247
to
414b86e
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/cherrypick release-0.16 |
|
@alvaroaleman: new pull request created: #2539 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to define a cache selector config that applies to all namespaces that themselves do not have an explicit config. An example would be "Cache all namespaces without selector, except for namespace foo, there use labelSelector bar=baz".
More as a side effect than intentionally, this also makes it valid to use the empty string as a key in the
NamespacesandbyObject.Namespacesconfig of the cache. This is very useful to for example have anamespaceCLI flag that might be empty.This change is the last missing bit to finish the implementation of the cache options design doc.
Sidenote: If someone can come up with a less wordy title that describes what this does, that would be nice :)