🌱 Add function RemoveControllerReference and HasControllerReference

[troy0820]

• Add function RemoveControllerReference to controllerutil
• Add function HasControllerReference to controllerutil
• Add tests for functions

When creating #2462 it was discussed that to achieve the ask of the issue #2381 two functions can help remove ControllerReferences to get around the errors of it not being able to be overwritten.

These two functions (and not to be confused with the original PR that allows removal of any owner reference), allows the caller to see if the owner reference they want to remove in fact is a "ControllerReference" (controller = true)

This functionality is present with finalizers and will be helpful when trying to mitigate issues with trying to overwrite the owner reference on an object.

[alvaroaleman]

thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, troy0820

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

@troy0820 Sorry for the late review :).

I'm not sure if this func works as intended. It first checks if there is a controller ownerRef on the object and then it removes the passed in owner. It doesn't check that the passed in owner is actually the controller (which I think is the goal of this func)

[troy0820]

Now looking at it, I’m not sure how I missed that. I’ll update the func to look if the owner is the controlled and remove that reference, otherwise it misses the goal as you said.

I’ll create an issue and assign it to me.