⚠ Minor improvements to godoc, code style in cache pkg #2416
+111
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/L
|
@sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
sbueringer
changed the title
alvaroaleman
approved these changes
Jul 24, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lleshchi
added a commit
to lleshchi/hive
that referenced
this pull request
Dec 18, 2023
lleshchi
added a commit
to lleshchi/hive
that referenced
this pull request
Dec 19, 2023
lleshchi
added a commit
to lleshchi/hive
that referenced
this pull request
Jan 5, 2024
lleshchi
added a commit
to lleshchi/hive
that referenced
this pull request
Jan 5, 2024
Fix breaking changes from upgrade of controller-runtime. Breaking changes from: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0 - kubernetes-sigs/controller-runtime#2407 - kubernetes-sigs/controller-runtime#2416 HIVE-2254 Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
lleshchi
added a commit
to lleshchi/hive
that referenced
this pull request
Jan 5, 2024
Fix breaking changes from upgrade of controller-runtime. Breaking changes from: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0 - kubernetes-sigs/controller-runtime#2407 - kubernetes-sigs/controller-runtime#2416 HIVE-2254 Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
lleshchi
added a commit
to lleshchi/hive
that referenced
this pull request
Jan 10, 2024
Fix breaking changes from upgrade of controller-runtime. Breaking changes from: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0 - kubernetes-sigs/controller-runtime#2407 - kubernetes-sigs/controller-runtime#2416 HIVE-2254 Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
lleshchi
added a commit
to lleshchi/hive
that referenced
this pull request
Jan 10, 2024
Fix breaking changes from upgrade of controller-runtime. Breaking changes from: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0 - kubernetes-sigs/controller-runtime#2407 - kubernetes-sigs/controller-runtime#2416 HIVE-2254 Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
lleshchi
added a commit
to lleshchi/hive
that referenced
this pull request
Jan 23, 2024
Fix breaking changes from upgrade of controller-runtime. Breaking changes from: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0 - kubernetes-sigs/controller-runtime#2407 - kubernetes-sigs/controller-runtime#2416 HIVE-2254 Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
lleshchi
added a commit
to lleshchi/hive
that referenced
this pull request
Jan 27, 2024
Fix breaking changes from upgrade of controller-runtime. Breaking changes from: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0 - kubernetes-sigs/controller-runtime#2407 - kubernetes-sigs/controller-runtime#2416 HIVE-2254 Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
lleshchi
added a commit
to lleshchi/hive
that referenced
this pull request
Jan 27, 2024
Fix breaking changes from upgrade of controller-runtime. Breaking changes from: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0 - kubernetes-sigs/controller-runtime#2407 - kubernetes-sigs/controller-runtime#2416 HIVE-2254 Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
lleshchi
added a commit
to lleshchi/hive
that referenced
this pull request
Jan 27, 2024
Fix breaking changes from upgrade of controller-runtime. Breaking changes from: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0 - kubernetes-sigs/controller-runtime#2407 - kubernetes-sigs/controller-runtime#2416 HIVE-2254 Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
lleshchi
added a commit
to lleshchi/hive
that referenced
this pull request
Jan 27, 2024
Fix breaking changes from upgrade of controller-runtime. Breaking changes from: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0 - kubernetes-sigs/controller-runtime#2407 - kubernetes-sigs/controller-runtime#2416 HIVE-2254 Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
lleshchi
added a commit
to lleshchi/hive
that referenced
this pull request
Feb 2, 2024
Fix breaking changes from upgrade of controller-runtime. Breaking changes from: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0 - kubernetes-sigs/controller-runtime#2407 - kubernetes-sigs/controller-runtime#2416 HIVE-2254 Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
lleshchi
added a commit
to lleshchi/hive
that referenced
this pull request
Feb 2, 2024
Fix breaking changes from upgrade of controller-runtime. Breaking changes from: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0 - kubernetes-sigs/controller-runtime#2407 - kubernetes-sigs/controller-runtime#2416 HIVE-2254 Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
lleshchi
added a commit
to lleshchi/hive
that referenced
this pull request
Feb 8, 2024
Fix breaking changes from upgrade of controller-runtime. Breaking changes from: https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.16.0 - kubernetes-sigs/controller-runtime#2407 - kubernetes-sigs/controller-runtime#2416 HIVE-2254 Signed-off-by: Leah Leshchinsky <lleshchi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.