Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.4] 🌱 Bump github.com/onsi/gomega from 1.27.4 to 1.27.5 #8402

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #8390

/assign killianmuldoon

@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Mar 28, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 28, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 28, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d62a39985c73841f3cf3f1bd55c880dbf71781bc

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2023
@fabriziopandini
Copy link
Member

/hold
@killianmuldoon what about deferring backport of this bump to after the release

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2023
@killianmuldoon
Copy link
Contributor

@killianmuldoon what about deferring backport of this bump to after the release

Sure - no issues with that

@killianmuldoon
Copy link
Contributor

/retest
/hold remove

@killianmuldoon
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit b6ea2c9 into kubernetes-sigs:release-1.4 Mar 28, 2023
10 checks passed
@sbueringer
Copy link
Member

I think the idea was to not backport all bumps, is there a specific reason for this one?

@killianmuldoon
Copy link
Contributor

I think the idea was to not backport all bumps, is there a specific reason for this one?

I don't think there was a specific motivation - more just a preference for bumping stuff when it's easy. Will be more conservative in future.

@sbueringer
Copy link
Member

sbueringer commented Apr 24, 2023

Yeah no problem. IIRC we updated the policy recently so we only backport if we have a reason like CVE's: https://cluster-api.sigs.k8s.io/contributing#backporting-a-patch

  • Dependency bumps for CVE (usually limited to CVE resolution; backports of non-CVE related version bumps are considered exceptions to be evaluated case by case)
  • Cert-manager version bumps (to avoid having releases with cert-manager versions that are out of support, when possible)

Otherwise we get a flood of cherry-picks for dependencies for all supported branches. (also some of those cherry-picks would propagate to CAPI consumers)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants