-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes tool generates duplicate release notes #10492
Comments
This issue is currently awaiting triage. CAPI contributors will take a look as soon as possible, apply one of the Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @g-gaston In case you have some context :) |
/priority important-soon |
@sbueringer how many PR entries you get in the markdown output? |
Dropping the |
Sorry should have attached this. Too much :) |
hey yall sorry it took me a bit Although I understand how the notes should look for pre-releases (and it's true that two sets of notes need to be generated), I do lack context about this feature and new code. I'm not sure what Maybe @chandankumar4 or @kubernetes-sigs/cluster-api-release-team may know something? |
Hmm that's weird, it definitely is related to #10091 where it prints the changes from the previous release version if it's a beta or rc release, then prints the changes since the last minor release in a dropdown. In your case, |
#10324 added logic to detect the release type: https://github.com/kubernetes-sigs/cluster-api/pull/10324/files#diff-42e246c09fe01942779ff9af547e932b606a68a6f692fe137b254e4a9a10da78R104 Maybe we can prevent |
Ah okay. Seems to work when I just don't specificy --previous-release-version. In the case I hit above it didn't add any details tag, it just ~ printed the entire release notes twice Ah, seems like that's because the release type is an empty string in my case.
I guess that makes sense I wonder why we only add details tags if previousRelease is also empty?
Maybe that flags is defined in a weird way to be honest. The flag seem to indirectly influence behavior based on the cases when we use the flag? Or maybe I"m just missing why details are only added if previous release is not set |
I'm not sure how the check works, it may have been added because of this comment about the e2e test: #10091 (comment) cc @chandankumar4 the current comms lead. I think there can be an improvement task for the comms team for simplifying the logic of |
Yeah, I agree!! I’ll open up an issue for simplifying the logic of “previous-release-version”. |
Hey folks,
I was trying to use the release-notes tool to generate release notes for CR. I hit two issues:
It was necessary to specifcy
branch
because we don't create release branches before the release in CR. Is this actually necessary? Could we e.g. maybe fallback if the branch doesn't exist? What was the difference again between calculating the diff based on a release branch or main?It generates duplicate notes
The text was updated successfully, but these errors were encountered: