Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.6] 馃悰 Restore v1alpha3/v1alpha4 conversion to fix SSA issue & add e2e test coverage #10151

Merged
merged 12 commits into from Feb 14, 2024
Merged

[release-1.6] 馃悰 Restore v1alpha3/v1alpha4 conversion to fix SSA issue & add e2e test coverage #10151

merged 12 commits into from Feb 14, 2024

Conversation

sbueringer
Copy link
Member

What this PR does / why we need it:
Manual cherry-pick of #10147

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Feb 14, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 14, 2024
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main-release-1-6

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-6
  • /test pull-cluster-api-e2e-blocking-release-1-6
  • /test pull-cluster-api-e2e-dualstack-and-ipv6-release-1-6
  • /test pull-cluster-api-e2e-mink8s-release-1-6
  • /test pull-cluster-api-e2e-release-1-6
  • /test pull-cluster-api-e2e-upgrade-1-28-1-29-release-1-6
  • /test pull-cluster-api-test-mink8s-release-1-6
  • /test pull-cluster-api-test-release-1-6
  • /test pull-cluster-api-verify-release-1-6

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-6

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-6
  • pull-cluster-api-build-release-1-6
  • pull-cluster-api-e2e-blocking-release-1-6
  • pull-cluster-api-test-release-1-6
  • pull-cluster-api-verify-release-1-6

In response to this:

/test pull-cluster-api-e2e-main-release-1-6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer added the area/e2e-testing Issues or PRs related to e2e testing label Feb 14, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Feb 14, 2024
@sbueringer sbueringer added area/api Issues or PRs related to the APIs do-not-merge/needs-area PR is missing an area label labels Feb 14, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Feb 14, 2024
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-release-1-6

@sbueringer sbueringer force-pushed the pr-1.6-fix-apiversion-issue-with-fix branch from 508272c to 028c823 Compare February 14, 2024 15:37
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-release-1-6

@g-gaston
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b49f736855ddae21d0de0b19b9481cbdd1bee5ac

@sbueringer sbueringer force-pushed the pr-1.6-fix-apiversion-issue-with-fix branch from 028c823 to bc778cd Compare February 14, 2024 17:13
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2024
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-release-1-6

Had a version mismatch v1.5.5 != v1.5.0. I think it worked locally because I still had v1.5.5 in _artifacts

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 211d90ccb0bfb8c2a75d00e7394cd0187576b402

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit ff6ed3f into kubernetes-sigs:release-1.6 Feb 14, 2024
21 checks passed
@sbueringer sbueringer deleted the pr-1.6-fix-apiversion-issue-with-fix branch February 14, 2024 18:49
@sbueringer sbueringer mentioned this pull request Feb 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@g-gaston g-gaston Awaiting requested review from g-gaston

Assignees

@fabriziopandini fabriziopandini

@g-gaston g-gaston

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sbueringer @k8s-ci-robot @g-gaston @fabriziopandini