Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 [release-1.6] Promote chrischdi to Cluster API maintainer #10089

Conversation

chrischdi
Copy link
Member

Manual cherry-pick of #9997

/area community-meeting

/assign sbueringer

/cherry-pick release-1.5

@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Feb 2, 2024
@k8s-ci-robot k8s-ci-robot added area/community-meeting Issues or PRs that should potentially be discussed in a Kubernetes community meeting. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 2, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 2, 2024
@chrischdi
Copy link
Member Author

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Is the owners file branch specific? i.e do you not have approve rights on release-1.6 currently?

I wasn't aware we had to update older branches like this.

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e316836f9558e2350032832b714a15a27692ee33

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2024
@chrischdi
Copy link
Member Author

Q: Is the owners file branch specific? i.e do you not have approve rights on release-1.6 currently?

I wasn't aware we had to update older branches like this.

/lgtm /approve /hold

Hmm good question 馃 cc @sbueringer I thought this was required 馃槀

@killianmuldoon
Copy link
Contributor

I hope it's not - otherwise we should really be doing this on all branches - even ones that are completely out of date IMO.

@sbueringer
Copy link
Member

I hope it's not - otherwise we should really be doing this on all branches - even ones that are completely out of date IMO.

Prow takes the OWNERS files from the branch you want to merge into. It has to, the folder structure could be entirely different.

In my opinion it's good enough to backport into active branches. There are still a lot of folks around who have approval rights on very old branches.

In any case. We have enough permissions on the repo, we can merge in every branch we want if necessary.

@sbueringer
Copy link
Member

/lgtm
/approve
/hold cancel

@chrischdi Feel free to prove it by trying to approve the release-1.5 cherry-pick :D

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [killianmuldoon,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 224cd76 into kubernetes-sigs:release-1.6 Feb 2, 2024
20 checks passed
@k8s-infra-cherrypick-robot

@chrischdi: new pull request created: #10090

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi chrischdi deleted the pr-cp-chrischdi-promotion-1-6 branch February 2, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-meeting Issues or PRs that should potentially be discussed in a Kubernetes community meeting. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants