Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.3] 馃尡 Bump go version to 1.21 #4803

Merged
merged 1 commit into from Feb 21, 2024
Merged

[release-2.3] 馃尡 Bump go version to 1.21 #4803

merged 1 commit into from Feb 21, 2024

Conversation

damdo
Copy link
Member

@damdo damdo commented Feb 21, 2024

What type of PR is this?
/kind support

What this PR does / why we need it:
Bump go version to 1.21, required by release tooling in the next minor version.

Release note:

Bump go version to 1.21

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/support Categorizes issue or PR as a support question. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 21, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 21, 2024
@damdo
Copy link
Member Author

damdo commented Feb 21, 2024

/assign @nrb @richardcase
/cc @AndiDog

@richardcase
Copy link
Member

@damdo - i suspect this will solve the issue from the cherry pick in #4801

@damdo
Copy link
Member Author

damdo commented Feb 21, 2024

@richardcase Yes, that's the plan 馃憤 Should we merge this first and retest the other one?

@richardcase
Copy link
Member

@richardcase Yes, that's the plan 馃憤 Should we merge this first and retest the other one?

Yes i think so

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit ddafd7b into kubernetes-sigs:release-2.3 Feb 21, 2024
13 checks passed
@richardcase richardcase mentioned this pull request Feb 23, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlipovetsky dlipovetsky Awaiting requested review from dlipovetsky

@fiunchinho fiunchinho Awaiting requested review from fiunchinho

@AndiDog AndiDog Awaiting requested review from AndiDog

Assignees

@richardcase richardcase

@nrb nrb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@damdo @richardcase @k8s-ci-robot @nrb