Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.3] 馃尡 Bump kubernetes/release notes tool to v0.16.5 #4801

Merged
merged 1 commit into from Feb 21, 2024
Merged

[release-2.3] 馃尡 Bump kubernetes/release notes tool to v0.16.5 #4801

merged 1 commit into from Feb 21, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #4798

/assign richardcase

NONE

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 20, 2024
Merged
5 tasks
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 20, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2024
@damdo
Copy link
Member

damdo commented Feb 20, 2024

/retest

@richardcase richardcase mentioned this pull request Feb 21, 2024
Merged
@richardcase
Copy link
Member

Having a look at this issue, we don't have separate jobs for the release-2.3 branch :(

@damdo
Copy link
Member

damdo commented Feb 21, 2024

/retest

@damdo
Copy link
Member

damdo commented Feb 21, 2024

Having a look at this issue, we don't have separate jobs for the release-2.3 branch :(

@richardcase what are the implications then?

damdo
damdo reviewed Feb 21, 2024
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2024
@richardcase
Copy link
Member

@richardcase what are the implications then?

We may not be running all the checks that we should. Also what checks that do run may be running with a base image that has newer dependencies.

We should create the jobs config for release-2.3....we can also take it as an opportunity to cleanup old jobs.

@richardcase
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6cfd980 into kubernetes-sigs:release-2.3 Feb 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

@AverageMarcus AverageMarcus Awaiting requested review from AverageMarcus

@cnmcavoy cnmcavoy Awaiting requested review from cnmcavoy

Assignees

@richardcase richardcase

@damdo damdo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k8s-infra-cherrypick-robot @damdo @richardcase @k8s-ci-robot @AndiDog