Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge OTEL metrics with legacy registerer #8594

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

zarvd
Copy link
Contributor

@zarvd zarvd commented Mar 12, 2025

What type of PR is this?

/kind feature

What this PR does / why we need it:

To export all metrics in 1 endpoint.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 12, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 12, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @zarvd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 12, 2025
Copy link
Contributor

@mainred mainred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not quite familiar withe old register we have, but left a comment.
And can you list the OTEL metrics from after merging the metrics from legacy register as a test?

@feiskyer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 12, 2025
@zarvd zarvd force-pushed the merge-metrics branch 5 times, most recently from 3e22f96 to 70e7f52 Compare March 14, 2025 02:15
@zarvd
Copy link
Contributor Author

zarvd commented Mar 14, 2025

/retest

@zarvd
Copy link
Contributor Author

zarvd commented Mar 14, 2025

@cvvz PTAL

@mainred
Copy link
Contributor

mainred commented Mar 14, 2025

/test pull-cloud-provider-azure-e2e-ccm-vmss-capz

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, zarvd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit b894900 into kubernetes-sigs:master Mar 17, 2025
17 of 18 checks passed
@zarvd zarvd deleted the merge-metrics branch March 17, 2025 06:58
zarvd added a commit to zarvd/cloud-provider-azure that referenced this pull request Mar 17, 2025
zarvd added a commit to zarvd/cloud-provider-azure that referenced this pull request Mar 17, 2025
zarvd added a commit to zarvd/cloud-provider-azure that referenced this pull request Mar 17, 2025
zarvd added a commit to zarvd/cloud-provider-azure that referenced this pull request Mar 17, 2025
zarvd added a commit to zarvd/cloud-provider-azure that referenced this pull request Mar 17, 2025
zarvd added a commit to zarvd/cloud-provider-azure that referenced this pull request Mar 17, 2025
k8s-ci-robot pushed a commit that referenced this pull request Mar 18, 2025
zarvd added a commit to zarvd/cloud-provider-azure that referenced this pull request Mar 18, 2025
k8s-ci-robot pushed a commit that referenced this pull request Mar 18, 2025
k8s-ci-robot pushed a commit that referenced this pull request Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants