-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release-note/changelog for v0.12.0 #126
Add release-note/changelog for v0.12.0 #126
Conversation
/assign @msau42 |
9c65c1c
to
f0248c6
Compare
CHANGELOG/CHANGELOG-0.12.md
Outdated
|
||
### Other (Cleanup or Flake) | ||
|
||
- Leader election is only supported for leases via NewLeaderElection. ([#109](https://github.com/kubernetes-csi/csi-lib-utils/pull/109), [@pohly](https://github.com/pohly)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this change is already part of v0.11.0. Not sure why it got picked up by the tool. https://github.com/kubernetes-csi/csi-lib-utils/blob/master/CHANGELOG/CHANGELOG-0.11.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The start sha should be f89955e. The start sha used in this run was before the 0.11 release. Please re-run it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed to use tags, this command works better:
release-notes \
--org=kubernetes-csi \
--repo=csi-lib-utils \
--start-rev=release-0.11 \
--discover=mergebase-to-latest \
--required-author="" \
--markdown-links \
--output out.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think --start-rev
is ignored if you use --discover
.
f0248c6
to
aa834d1
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, sunnylovestiramisu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
I ran release note sha diff of:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: