add WithCustomRegistry for metrics

[ayanamist]

What type of PR is this?

/kind feature

What this PR does / why we need it:
If users want to monitor workqueue metrics, they usually import k8s.io/component-base/metrics/prometheus/workqueue, which registers to k8s.io/component-base/metrics/legacyregistry, however, csiMetricsManager is using its own newly-created registry.

Which issue(s) this PR fixes:
Make a new method WithCustomRegistry to let users pass in an exist registry.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Adds WithCustomRegistry method to the metrics pkg to allow reuse of an existing registry.

[k8s-ci-robot]

Welcome @ayanamist!

It looks like this is your first PR to kubernetes-csi/csi-lib-utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-lib-utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ayanamist. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ggriffiths]

/ok-to-test

[ggriffiths]

I don't see any issues with this change. Can you clarify the release note though? Something like this-

Adds WithCustomRegistry method to the metrics pkg to allow reuse of an existing registry.

[ggriffiths]

/lgtm

[ayanamist]

I don't see any issues with this change. Can you clarify the release note though? Something like this-

Adds WithCustomRegistry method to the metrics pkg to allow reuse of an existing registry.

Do you mean edit the content of PR or commit message? I have modified both.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[ayanamist]

/remove-lifecycle stale

[sunnylovestiramisu]

Is this compatible with k8s.io/component-base v0.26.0?

[ayanamist]

Is this compatible with k8s.io/component-base v0.26.0?

Yes, it is compatible.

[msau42]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayanamist, ggriffiths, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment