feat(GH workflow): migrate postsubmit tests to github actions. Fixes #10747 #10824
Conversation
|
Hi @VDliveson. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: VDliveson <vanshajduggal1234@gmail.com>
VDliveson
force-pushed
the
postsubmit-tests
branch
from
54e9650
to
59406ce
Compare
|
/ok-to-test |
.github/workflows/postsubmit.yml
Outdated
| with: | ||
| cluster_name: build-kubeflow | ||
| - name: Run tests | ||
| run: | |
There was a problem hiding this comment.
I believe you would need to add backlashes \ at the end of each line in this command. Here's how you can format it correctly:
run: |
./test/postsubmit-tests-with-pipeline-deployment.sh \
--kfp_deployment mkp \
--workflow_file e2e_test_gke_v2.yaml \
--test_result_folder e2e_test \
--timeout "7200"
or you can format it to be in a single line:
run: ./test/postsubmit-tests-with-pipeline-deployment.sh --kfp_deployment mkp --workflow_file e2e_test_gke_v2.yaml --test_result_folder e2e_test --timeout "7200"
Signed-off-by: VDliveson <vanshajduggal1234@gmail.com>
VDliveson
force-pushed
the
postsubmit-tests
branch
from
179b536
to
bb2f337
Compare
|
@VDliveson have you tried testing this GH Action on your fork? If yes, could you please provide the link to a successful run? |
| @@ -39,7 +39,7 @@ jobs: | |||
| with: | |||
| cluster_name: build-kubeflow | |||
| - name: Run tests | |||
| run: | | |||
| run: > | |||
There was a problem hiding this comment.
have you tested this out? I believe backslashes would be required even with the folded style.
There was a problem hiding this comment.
Will update this but this still must work
There was a problem hiding this comment.
|
@DharmitD Kindly also take a look at the periodic functional tests and is there any way to disable it. I've been spammed with 100+ mails with failed workflow. Also the old tests need python 3.7 version but we get this error on python 3.7 
|
https://github.com/VDliveson/pipelines/actions/workflows/postsubmit.yml |
@VDliveson I'm looking into periodic tests GH Action and it looks like it's scheduled to run every 5 minutes, that's the problem. I will bring this up in community but make sure to turn off email notifications for repo GH Actions so it doesn't incessantly ping you with so many notifications. |
|
@chensun looks like the postsubmit prow config forwards test results to TestGrid: https://github.com/GoogleCloudPlatform/oss-test-infra/blob/master/prow/prowjobs/kubeflow/pipelines/kubeflow-pipelines-postsubmits.yaml#L14 |
Description of your changes:
Adds Github actions for postsubmit tests on push to master or release branch. Fixes #10747
Checklist:
cc @rimolive