Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Seldon 1.18.x and the corresponding owners file and github workflow #2673

Closed
juliusvonkohout opened this issue Apr 8, 2024 · 7 comments · Fixed by #2719
Closed
Assignees

Comments

@juliusvonkohout
Copy link
Member

We want to support Kubernetes 1.27 -1.29 in Kubeflow 1.9 and should update to Seldon 1.18+

https://docs.seldon.io/projects/seldon-core/en/latest/reference/upgrading.html

and there is discussion in #2532 (comment)

@rimolive @adriangonz @ramonpzg

@rimolive
Copy link
Member

Who are the code owners for Seldon? Is there an ETA for that upgrade?

I don't think this is a blocker for KF 1.9 and Seldon is not part of the core components, but if they're willing to do that we can plan for a patch release in 1.9.

@juliusvonkohout
Copy link
Member Author

The new code owners are described in #2532 (comment)

We can also write a synchronization script ourselves.

@rimolive
Copy link
Member

Your call. As far as I know the manifest sync scripts are only for the core components, and since we need to write one for Model Registry (the team is about to send a PR for it) we can try write one for Seldon if, and only if, this won't take much time and effort. We have to set hard feature freeze date by Apr 22nd or the original schedule might be compromised.

@juliusvonkohout
Copy link
Member Author

juliusvonkohout commented May 16, 2024

@lampajr can you tackle this and add a synchronization script as well?

@juliusvonkohout juliusvonkohout changed the title Update to Seldon 1.18.x and the corresponding owners file Update to Seldon 1.18.x and the corresponding owners file and github workflow May 16, 2024
@lampajr
Copy link
Member

lampajr commented May 16, 2024

@lampajr can you tackle this and add a synchronization script as well?

Hi Julius, I gave it a quick try following https://github.com/kubeflow/manifests/blob/master/contrib/seldon/UPGRADE.md but it looks like the chart for the latest v1.18.1 release are not present in the helm chart repo https://storage.googleapis.com/seldon-charts

Do you know how can we get those charts there?

@juliusvonkohout
Copy link
Member Author

@lampajr
Copy link
Member

lampajr commented May 17, 2024

@lampajr Maybe from here https://docs.seldon.io/projects/seldon-core/en/latest/workflow/install.html#seldon-core-kustomize-install

I think I can find a way directly cloning the seldon-core repo, will try this later today

Needs Triage automation moved this from To Do to Closed May 21, 2024
@kubeflow-bot kubeflow-bot removed this from Closed in Needs Triage May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants