Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ring/aws-lc-rs docs and feature tweak #1720

Merged
merged 1 commit into from
Mar 12, 2025
Merged

ring/aws-lc-rs docs and feature tweak #1720

merged 1 commit into from
Mar 12, 2025

Conversation

clux
Copy link
Member

@clux clux commented Mar 12, 2025

the dev dep of kube to a feature that does not yet exist prevents a release atm

dry-run output:

   Packaging kube-client v0.98.0 (/kube/kube/kube-client)
    Updating crates.io index
error: failed to prepare local package for uploading

Caused by:
  failed to select a version for `kube`.
      ... required by package `kube-client v0.98.0 (/kube/kube/kube-client)`
  versions that meet the requirements `<1.0.0, >=0.61.0` are: 0.98.0, 0.97.0, 0.96.0, 0.95.0, 0.94.2, 0.94.1, 0.94.0, 0.93.1, 0.93.0, 0.92.1, 0.92.0, 0.91.0, 0.90.0, 0.89.0, 0.88.1, 0.88.0, 0.87.2, 0.87.1, 0.85.0, 0.84.0, 0.83.0, 0.82.2, 0.82.1, 0.82.0, 0.81.0, 0.80.0, 0.79.0, 0.78.0, 0.77.0, 0.76.0, 0.75.0, 0.74.0, 0.73.1, 0.73.0, 0.72.0, 0.71.0, 0.70.0, 0.69.1, 0.69.0, 0.68.0, 0.67.0, 0.66.0, 0.65.0, 0.64.0, 0.63.2, 0.63.1, 0.63.0, 0.62.0, 0.61.0

  the package `kube-client` depends on `kube`, with features: `ring` but `kube` does not have these features.

if we can bypass the dev dep feature, then this should work, running through ci to verify tests (which is ultimately what the dev dep is for).

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux marked this pull request as ready for review March 12, 2025 12:32
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.1%. Comparing base (56109ad) to head (4e86e51).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1720   +/-   ##
=====================================
  Coverage   76.1%   76.1%           
=====================================
  Files         84      84           
  Lines       7859    7859           
=====================================
  Hits        5976    5976           
  Misses      1883    1883           
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clux
Copy link
Member Author

clux commented Mar 12, 2025

passes CI, so should be good!

@clux clux added this to the 0.99.0 milestone Mar 12, 2025
@clux clux added the changelog-exclude changelog excluded prs label Mar 12, 2025
@clux clux merged commit 486ac5f into main Mar 12, 2025
17 checks passed
@clux clux deleted the ring-follow-up branch March 12, 2025 12:34
@clux
Copy link
Member Author

clux commented Mar 12, 2025

ugh, but it still claims we depend on kube-client with ring on publish...

Caused by:
  failed to select a version for `kube-client`.
      ... required by package `kube v0.98.0 (/kube/kube/kube)`
  versions that meet the requirements `=0.98.0` are: 0.98.0

  the package `kube` depends on `kube-client`, with features: `ring` but `kube-client` does not have these features.

will make a second follow-up...

@clux
Copy link
Member Author

clux commented Mar 12, 2025

Coming back to it, I think the rest is merely errors in dry-run, that will either resolve themselves during actual publish, or can be overridden to manually publish kube last to fix it. Will try to get 0.99.0 out the door.

EDIT: this was correct. No manual stuff needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant