KTOR-5199 Support WebSockets in Curl engine #4656
Merged
+454
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts" (commit 6438787) but leaves test to fix HTTP timeout tests
whyoleg
force-pushed
the
whyoleg/curl-ws
branch
from
e729516 to
ef6380a
Compare
|
@whyoleg, could you check the CI? |
|
looks like flaky, restarted |
e5l
approved these changes
Feb 7, 2025
auto-merge was automatically disabled
February 8, 2025 06:26
Head branch was pushed to by a user without write access
|
I've reverted additional commit which drops |
osipxd
approved these changes
Feb 9, 2025
ktor-client/ktor-client-curl/desktop/src/io/ktor/client/engine/curl/internal/NativeUtils.kt
Outdated
Show resolved
Hide resolved
e5l
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopens #3950 rebased on latest
mainwith small fixes:dropreverted in 66eb2e7 as it's caused test failuresrunBlockingin one placeNote: for some reason we doesn't get a response when empty frame is sent, so I've ignored test for now:
e729516#diff-109d21786a3c9fc1fa41ca37d161e2099fc7091eee7a13f8e1627df3ba1c391dR39
Not sure if it's a curl issue - need to be investigated
Note2: commit 6438787 was mostly reverted as it was causing failures in http timeout tests