Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KTOR-6878 Fix stack overflow when SuspendFunctionGun trying to access… #4007

Merged
merged 3 commits into from Mar 28, 2024
Merged

KTOR-6878 Fix stack overflow when SuspendFunctionGun trying to access… #4007

merged 3 commits into from Mar 28, 2024

Conversation

Stexxe
Copy link
Contributor

@Stexxe Stexxe commented Mar 27, 2024

@Stexxe
KTOR-6878 Fix stack overflow when SuspendFunctionGun trying to access…
5beb308 
… continuation context of the same continuation object recursively
@Stexxe Stexxe requested a review from e5l March 27, 2024 11:30
e5l
e5l approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Stexxe Stexxe merged commit 9c78494 into main Mar 28, 2024
14 of 16 checks passed
@Stexxe Stexxe deleted the stexxe/functiongun-stackoverflow branch March 28, 2024 07:57
@mgroth0
Copy link

mgroth0 commented Mar 28, 2024 •
edited

Hi,

Thanks for fixing this! Is this commit included in 3.0.0-beta-2-eap-925/? I am not sure how see a record of which commits are included an EAP release since I cannot see any branches, releases, or tags for a particular EAP build

@mgroth0
Copy link

mgroth0 commented Mar 29, 2024

I actually checked 3.0.0-beta2-eap-925 and this time got a different error. See https://youtrack.jetbrains.com/issue/KTOR-6878/JS-browser-Maximum-call-stack-size-exceeded-on-HTTP-request-when-targeting-es2015#focus=Comments-27-9611391.0-0

e5l pushed a commit that referenced this pull request Apr 4, 2024
@Stexxe @e5l
KTOR-6878 Fix stack overflow when SuspendFunctionGun trying to access… (
12d59d8 
#4007)

* KTOR-6878 Fix stack overflow error when SuspendFunctionGun tries to access continuation context of the same continuation object recursively

(cherry picked from commit 9c78494)
e5l pushed a commit that referenced this pull request Apr 5, 2024
@Stexxe @e5l
KTOR-6878 Fix stack overflow when SuspendFunctionGun trying to access… (
0c0e0a3 
#4007)

* KTOR-6878 Fix stack overflow error when SuspendFunctionGun tries to access continuation context of the same continuation object recursively

(cherry picked from commit 9c78494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e5l e5l e5l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Stexxe @mgroth0 @e5l