You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In our CI process, Cpplint is set up to check files that have been modified as identified by git diff.
However, CI skips files that have been moved, because it can not open and read them.
For instance, in commit 5023e99, the paths of permutation_argument_stringifer.h and permutation_verifying_key_stringifier.h were changed. This change led to an oversight of a header guard typo, as the CI process skipped these files.
Expected Behavior?
Due to the extensive size of our codebase, running Cpplint on the entire code is not efficient. Therefore, we aim to check only the modified files. However, the process needs enhancement to ensure that files with changed paths (moved files) are not skipped and are thoroughly checked.
Standalone code or description to reproduce the issue
Introduce an intentional error recognizable by Cpplint, such as an inappropriate header guard, in a file.
Move the file to a different directory.
Run the CI process and observe if Cpplint checks the moved file.
Further details can be found in commit 5023e99 and its CI Log.
The text was updated successfully, but these errors were encountered:
Current behavior?
In our CI process, Cpplint is set up to check files that have been modified as identified by
git diff
.However, CI skips files that have been moved, because it can not open and read them.
For instance, in commit 5023e99, the paths of
permutation_argument_stringifer.h
andpermutation_verifying_key_stringifier.h
were changed. This change led to an oversight of a header guard typo, as the CI process skipped these files.Expected Behavior?
Due to the extensive size of our codebase, running Cpplint on the entire code is not efficient. Therefore, we aim to check only the modified files. However, the process needs enhancement to ensure that files with changed paths (moved files) are not skipped and are thoroughly checked.
Standalone code or description to reproduce the issue
Further details can be found in commit 5023e99 and its CI Log.
The text was updated successfully, but these errors were encountered: