Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use URI.open in ruby > 2.5 #45

Merged
merged 4 commits into from
Jan 29, 2021
Merged

Use URI.open in ruby > 2.5 #45

merged 4 commits into from
Jan 29, 2021

Conversation

v-kumar
Copy link

@v-kumar v-kumar commented Jan 16, 2021

Ruby 2.7 deprecates use of Kernel#open. Recommends URI.open.

Also, the fix done for 6.4.0 using self.open is broken in ruby 2.6. i.e., 6.4 version of the gem errs in 2.6.6.

This PR addresses issue #44

@v-kumar
Use URI.open in ruby > 2.5
fdfb761 
Ryb 2.7 deprecates use of Kernel#open. Recommends URI.open.

Also, the fix done for 6.4.0 using self.open is broken in ruby 2.6. i.e., 6.4 version of the gem errs in 2.6.6.
@v-kumar v-kumar mentioned this pull request Jan 16, 2021
Closed
sbhawsingka
sbhawsingka reviewed Jan 18, 2021
View reviewed changes
Copy link
Collaborator

@sbhawsingka sbhawsingka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, can you please fix the spec? @v-kumar. Thanks!

EmmaB added a commit to GeneralProducts/kt-paperclip that referenced this pull request Jan 21, 2021
@EmmaB
Update uri_adapter.rb
19ca1df 
Include PR from kreeti#45
@ssinghi ssinghi merged commit fd765fb into kreeti:master Jan 29, 2021
@ssinghi
Copy link

ssinghi commented Jan 29, 2021

Thank you @v-kumar!

@v-kumar
Copy link
Author

v-kumar commented Jan 29, 2021

@ssinghi Any estimate on when 6.4.1 could be released?

@manuelmeurer manuelmeurer mentioned this pull request Feb 25, 2021
Closed
remmons added a commit to AdWerx/paperclip that referenced this pull request Sep 26, 2023
@remmons
Use URI.open in ruby > 2.5
4fa3c84 
Cherry picked: kreeti#45
Original issue: kreeti#44

Fixes issue with deprecation warnings related to
remmons added a commit to AdWerx/paperclip that referenced this pull request Sep 26, 2023
@remmons
Use URI.open in ruby > 2.5
569d6ff 
Cherry picked: kreeti#45
Original issue: kreeti#44

Fixes issue with deprecation warnings related to: "warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open"
remmons added a commit to AdWerx/paperclip that referenced this pull request Sep 26, 2023
@remmons
Use URI.open in ruby > 2.5
db94e3f 
Cherry picked: kreeti#45
Original issue: kreeti#44

Fixes issue with deprecation warnings related to: "warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open"
remmons added a commit to AdWerx/paperclip that referenced this pull request Sep 26, 2023
@remmons
Use URI.open in ruby > 2.5
1c921d4 
Cherry picked: kreeti#45
Original issue: kreeti#44

Fixes issue with deprecation warnings related to: "warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open"
remmons added a commit to AdWerx/paperclip that referenced this pull request Sep 26, 2023
@remmons
Use URI.open in ruby > 2.5
0683fce 
Cherry picked: kreeti#45
Original issue: kreeti#44

Fixes issue with deprecation warnings related to: "warning: calling URI.open via Kernel#open is deprecated, call URI.open directly or use URI#open"
@remmons remmons mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbhawsingka sbhawsingka sbhawsingka approved these changes

Assignees

@ssinghi ssinghi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@v-kumar @ssinghi @sbhawsingka