Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump gorilla websocket to 1.5.1+ #14597

Open
nak3 opened this issue Nov 7, 2023 · 5 comments
Open

Bump gorilla websocket to 1.5.1+ #14597

nak3 opened this issue Nov 7, 2023 · 5 comments
Labels
area/build Build topics specifically related to Knative kind/bug Categorizes issue or PR as related to a bug.

Comments

@nak3
Copy link
Contributor

nak3 commented Nov 7, 2023 •
edited by ReToCode

/area build

Since upstream gorilla websocket changed SetCloseHandler to handle a returned error from WriteControl():

https://github.com/gorilla/websocket/blob/666c197fc9157896b57515c3a3326c3f8c8319fe/conn.go#L1166-L1168

serving's unit test TestServerShutdown() started failing as websocket does not return CloseError.
We temporary pin to gorilla websocket to 1.5.0 but should be fixed.

Please refer to #14588 for the error log.
@nak3 nak3 added the kind/bug Categorizes issue or PR as related to a bug. label Nov 7, 2023
@knative-prow knative-prow bot added the area/build Build topics specifically related to Knative label Nov 7, 2023
@nak3 nak3 mentioned this issue Nov 7, 2023
Merged
@ReToCode ReToCode changed the title Bump gorilla websocket to 1.15.1+ Bump gorilla websocket to 1.5.1+ Nov 7, 2023
@nak3 nak3 added this to the v1.13.0 milestone Nov 7, 2023
@nak3 nak3 self-assigned this Nov 7, 2023
@nak3
Copy link
Contributor Author

nak3 commented Dec 1, 2023

Working in progress gorilla/websocket#863

nak3 added a commit to nak3/serving that referenced this issue Jan 22, 2024
@nak3
Bump gorilla websocket to 1.5.1+
9a6ab77 
As gorilla/websocket#863 was merged, we can bump the gorilla websocket to the latest version.

Fix knative#14597
@nak3
Copy link
Contributor Author

nak3 commented Jan 31, 2024

Ugh... gorilla/websocket#863 was merged but there is still a log noise issue gorilla/websocket#880 in 1.5.1...

@nak3 nak3 removed their assignment Jan 31, 2024
@ReToCode
Copy link
Member

Thanks, we'll track gorilla/websocket#880 then.

@ReToCode ReToCode mentioned this issue Feb 26, 2024
Open
1 task
@dprotaso dprotaso removed this from the v1.13.0 milestone Mar 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2024
@ReToCode
Copy link
Member

ReToCode commented Jun 3, 2024

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build Build topics specifically related to Knative kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dprotaso @nak3 @ReToCode