Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-gateway-api nightly #14531

Merged

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Oct 17, 2023

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in net-gateway-api.yaml istio-gateway.yaml gateway-api.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-gateway-api/latest/$x > ${GITHUB_WORKSPACE}/./third_party/gateway-api-latest/$x
done

Details:

bumping knative.dev/net-gateway-api 33eb24c...a198125:
  > a198125 Wait for deploy/gateway-api-admission-server to make sure webhook is ready (# 573)
  > 0e28e43 added gateway api crds file to the release from the third party folder (# 571)
  > 4089d16 Re-enable random cluster suffix (# 572)
  > 2067a63 Bump Istio to 1.19.3 (# 568)
  > ab71c8a upgrade to latest dependencies (# 569)
  > 0a41f16 removed duplicated section from docs (# 564)
  > 7509cfa Update community files (# 565)
  > 7f17c8e upgrade to latest dependencies (# 567)
  > c8b30f0 Remove api gateway crds (# 557)
  > bd2d261 Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 (# 563)

@knative-prow knative-prow bot requested a review from a team October 17, 2023 11:05
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/networking labels Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52a25fa) 86.01% compared to head (86711a8) 85.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14531      +/-   ##
==========================================
- Coverage   86.01%   85.98%   -0.04%     
==========================================
  Files         197      197              
  Lines       14915    14915              
==========================================
- Hits        12829    12824       -5     
- Misses       1776     1779       +3     
- Partials      310      312       +2     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-automation knative-automation force-pushed the update-nightly/net-gateway-api branch 2 times, most recently from ecd95d2 to e296c0c Compare October 19, 2023 11:05
@dprotaso
Copy link
Member

/hold nightly build failed so a file is missing

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2023
@ReToCode
Copy link
Member

@gabo1208 mind to take a look. It might be that this is related to your changes https://github.com/knative-extensions/net-gateway-api/commits?author=gabo1208

@nak3
Copy link
Contributor

nak3 commented Oct 20, 2023

The failed curl command is working now as below so I guess third_party/gateway-api-latest/gateway-api.yaml will be updated with next push?

$ curl  https://storage.googleapis.com/knative-nightly/net-gateway-api/latest/gateway-api.yaml 

@gabo1208
Copy link
Member

I can manually add the file or should we wait for the next nightly build??

bumping knative.dev/net-gateway-api 33eb24c...a198125:
  > a198125 Wait for deploy/gateway-api-admission-server to make sure webhook is ready (# 573)
  > 0e28e43 added gateway api crds file to the release from the third party folder (# 571)
  > 4089d16 Re-enable random cluster suffix (# 572)
  > 2067a63 Bump Istio to 1.19.3 (# 568)
  > ab71c8a upgrade to latest dependencies (# 569)
  > 0a41f16 removed duplicated section from docs (# 564)
  > 7509cfa Update community files (# 565)
  > 7f17c8e upgrade to latest dependencies (# 567)
  > c8b30f0 Remove api gateway crds (# 557)
  > bd2d261 Bump github.com/google/go-cmp from 0.5.9 to 0.6.0 (# 563)

Signed-off-by: Knative Automation <automation@knative.team>
@nak3
Copy link
Contributor

nak3 commented Oct 20, 2023

/lgtm
/approve

It seems that today's push updated third_party/gateway-api-latest/gateway-api.yaml correctly 🎉 . So manual operation is not necessary.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@nak3 nak3 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2023
@knative-prow knative-prow bot merged commit 425abcb into knative:main Oct 20, 2023
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants