Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.11] bump x/net to v0.17 #14516

Merged
merged 3 commits into from Oct 12, 2023
Merged

[release-1.11] bump x/net to v0.17 #14516

merged 3 commits into from Oct 12, 2023

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Oct 12, 2023

Part of: #14506

This patch is same with #14512 against 1.11 branch.

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 12, 2023
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2023
@nak3
Copy link
Contributor Author

nak3 commented Oct 12, 2023 •
edited

x/net is used only by test so I think it is not mandatory. But I think we should bump if #14500 will make a new release.

EDIT: It was used in vendor/knative.dev/pkg/network/h2c.go

@nak3 nak3 changed the title [release-1.11] bump x/net to v1.17 [release-1.11] bump x/net to v0.17 Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (fb9129c) 86.29% compared to head (0435cf6) 86.29%.

Additional details and impacted files 
@@              Coverage Diff              @@
##           release-1.11   #14516   +/-   ##
=============================================
  Coverage         86.29%   86.29%           
=============================================
  Files               199      199           
  Lines             14814    14814           
=============================================
  Hits              12784    12784           
+ Misses             1730     1729    -1     
- Partials            300      301    +1

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Oct 12, 2023
ReToCode
ReToCode approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@ReToCode ReToCode mentioned this pull request Oct 12, 2023
Closed
30 tasks
@nak3
Copy link
Contributor Author

nak3 commented Oct 12, 2023

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2023
@nak3
Copy link
Contributor Author

nak3 commented Oct 12, 2023

/hold

@nak3
Copy link
Contributor Author

nak3 commented Oct 12, 2023

x/net is used only by test so I think it is not mandatory. But I think we should bump if #14500 will make a new release.

Answer it by myself. We need to pull knative/pkg#2860 into serving repo. I will update this PR.

@ReToCode ReToCode mentioned this pull request Oct 12, 2023
Merged
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
ReToCode
ReToCode approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nak3 nak3 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2023
@knative-prow knative-prow bot merged commit 4ff7168 into knative:release-1.11 Oct 12, 2023
61 checks passed
@nak3 nak3 mentioned this pull request Oct 13, 2023
Closed
openshift-ci bot pushed a commit to openshift-knative/serving that referenced this pull request Oct 16, 2023
@ReToCode @knative-prow-robot
@KauzClay @nak3
[release-1.11] sync with upstream to include CVE patches (#472)
daa44ca 
* [release-1.11] fix securityContext for Knative Service Pod (user-container and queue-proxy) (knative#14378)

* add seccompProfile to queue container security context

* run as non root by default

* update tests to expect new default run as nonroot

---------

Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com>

* Leave a comment which will trigger a new dot release (knative#14500)

* [release-1.11] bump x/net to v0.17 (knative#14516)

* [release-1.11] bump x/net to v1.17

* Re-generate test/config/tls/cert-secret.yaml (knative#14324)

* Run hack/update-codegen.sh --upgrade --release 1.11

* Update secure-pod-defaults patch

---------

Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team>
Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
openshift-ci bot pushed a commit to openshift-knative/serving that referenced this pull request Oct 20, 2023
@ReToCode @knative-prow-robot
@KauzClay @nak3 @evankanderson
[release-1.11] sync with upstream (#489)
b504942 
* [release-1.11] fix securityContext for Knative Service Pod (user-container and queue-proxy) (knative#14378)

* add seccompProfile to queue container security context

* run as non root by default

* update tests to expect new default run as nonroot

---------

Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com>

* Leave a comment which will trigger a new dot release (knative#14500)

* [release-1.11] bump x/net to v0.17 (knative#14516)

* [release-1.11] bump x/net to v1.17

* Re-generate test/config/tls/cert-secret.yaml (knative#14324)

* Run hack/update-codegen.sh --upgrade --release 1.11

* Bound buffer for reading stats (knative#14542)

Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>

---------

Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team>
Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
openshift-merge-bot bot pushed a commit to openshift-knative/serving that referenced this pull request Jan 8, 2024
@ReToCode @knative-prow-robot
@KauzClay @nak3 @evankanderson @knative-automation @jsanin-vmw @k4leung4 @dprotaso
[RELEASE-1.11] Sync with upstream release-1.11 (#580)
9bd87d6 
* [release-1.11] fix securityContext for Knative Service Pod (user-container and queue-proxy) (knative#14378)

* add seccompProfile to queue container security context

* run as non root by default

* update tests to expect new default run as nonroot

---------

Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com>

* Leave a comment which will trigger a new dot release (knative#14500)

* [release-1.11] bump x/net to v0.17 (knative#14516)

* [release-1.11] bump x/net to v1.17

* Re-generate test/config/tls/cert-secret.yaml (knative#14324)

* Run hack/update-codegen.sh --upgrade --release 1.11

* Bound buffer for reading stats (knative#14542)

Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>

* upgrade to latest dependencies (knative#14552)

bumping knative.dev/pkg bd99f2f...56bfe0d:
  > 56bfe0d [release-1.11] [CVE-2023-44487] Disable http2 for webhooks (# 2875)
bumping knative.dev/caching 24ff723...ee89f75:
  > ee89f75 upgrade to latest dependencies (# 797)

Signed-off-by: Knative Automation <automation@knative.team>

* Upgrade grpc for addressing GHSA-m425-mq94-257g (knative#14579)

More info at GHSA-m425-mq94-257g

* remove duplicate 'additionalPrinterColumns' (knative#14654)

Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Co-authored-by: Kenny Leung <kleung@chainguard.dev>

* [release-1.11] Bump to fix knative#14732 (knative#14734)

* Bump to fix knative#14732

* Bump to fix serving/knative#14732

* Sync with upstream release-1.11

---------

Signed-off-by: Knative Automation <automation@knative.team>
Signed-off-by: Kenny Leung <kleung@chainguard.dev>
Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team>
Co-authored-by: Clay Kauzlaric <ckauzlaric@vmware.com>
Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com>
Co-authored-by: Evan Anderson <evan.k.anderson@gmail.com>
Co-authored-by: Knative Automation <automation@knative.team>
Co-authored-by: Juan Sanin <jsanin@vmware.com>
Co-authored-by: Kenny Leung <kleung@chainguard.dev>
Co-authored-by: Dave Protasowski <dprotaso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@jsanin-vmw jsanin-vmw Awaiting requested review from jsanin-vmw

@xtreme-vikram-yadav xtreme-vikram-yadav Awaiting requested review from xtreme-vikram-yadav

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nak3 @ReToCode