Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell executor logs through testing.T in upgrade tests #7367

Merged
merged 5 commits into from
Oct 23, 2023

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Oct 16, 2023

Similar to knative/serving#14495

Fixes #

Proposed Changes

  • Print logs from shell executor to testing.T so that the logs can be found within test scope

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note


Docs

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/test-and-release Test infrastructure, tests or release size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 16, 2023
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9314d8) 76.87% compared to head (a0505b4) 76.84%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7367      +/-   ##
==========================================
- Coverage   76.87%   76.84%   -0.03%     
==========================================
  Files         252      252              
  Lines       13822    13822              
==========================================
- Hits        10625    10622       -3     
- Misses       2667     2669       +2     
- Partials      530      531       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgencur
Copy link
Contributor Author

mgencur commented Oct 16, 2023

Printing within test scope can be seen in this run
Now removing the temporary commit to make the tests pass.

@mgencur mgencur changed the title [WIP] Shell executor logs through testing.T in upgrade tests Shell executor logs through testing.T in upgrade tests Oct 16, 2023
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2023
@mgencur
Copy link
Contributor Author

mgencur commented Oct 17, 2023

/test reconciler-tests

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@knative-prow knative-prow bot merged commit b5fd264 into knative:main Oct 23, 2023
37 of 41 checks passed
@knative-prow
Copy link

knative-prow bot commented Oct 23, 2023

@mgencur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
upgrade-tests_eventing_main a0505b4 link unknown /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants