Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase expiration buffer time of OIDCTokenProviders cache to 5 minutes #7355

Merged
merged 3 commits into from Oct 18, 2023
Merged

Increase expiration buffer time of OIDCTokenProviders cache to 5 minutes #7355

merged 3 commits into from Oct 18, 2023

Conversation

akagami-harsh
Copy link
Contributor

…ers cache to 5 minuets

Fixes #7351

Proposed Changes

  • Increased OIDC token expiration time to 5 minuets

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Docs

@akagami-harsh
Fix: Issue knative#7351 Increasing expiration buffer time of OIDCToke…
b59c9d3 
…nProviders cache to 5 minuets

Signed-off-by: Harshvir Potpose <hpotpose62@gmail.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 12, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot requested review from Cali0707 and lberk October 12, 2023 08:34
@knative-prow
Copy link

knative-prow bot commented Oct 12, 2023

Welcome @akagami-harsh! It looks like this is your first PR to knative/eventing 🎉

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 12, 2023

Hi @akagami-harsh. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member

Thanks @akagami-harsh

@akagami-harsh @pierDipi
Update pkg/auth/token_provider.go
bcd8fa2 
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@akagami-harsh
Copy link
Contributor Author

please add the hackotberfest tag

@Cali0707
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (494ebb2) 76.84% compared to head (9aa46e2) 76.84%.
Report is 13 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7355   +/-   ##
=======================================
  Coverage   76.84%   76.84%           
=======================================
  Files         252      252           
  Lines       13727    13822   +95     
=======================================
+ Hits        10548    10622   +74     
- Misses       2652     2669   +17     
- Partials      527      531    +4
Files Coverage Δ
pkg/auth/token_provider.go 0.00% <ø> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@creydr
Copy link
Member

creydr commented Oct 13, 2023

Thanks for your contribution @akagami-harsh 🎉

/retitle Increase expiration buffer time of OIDCTokenProviders cache to 5 minutes
/retest

@knative-prow knative-prow bot changed the title Fix: Issue #7351 Increasing expiration buffer time of OIDCTokenProvid... Increase expiration buffer time of OIDCTokenProviders cache to 5 minutes Oct 13, 2023
@Leo6Leo
Copy link
Member

Leo6Leo commented Oct 18, 2023

/lgtm
/cc @creydr @pierDipi @Cali0707

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
Cali0707
Cali0707 reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akagami-harsh can you update the comment on line 76 to indicate that we are now using a buffer of 5min, not 30 seconds?

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@akagami-harsh
Copy link
Contributor Author

@akagami-harsh can you update the comment on line 76 to indicate that we are now using a buffer of 5min, not 30 seconds?

done

@Cali0707
Copy link
Member

/retest

Cali0707
Cali0707 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @akagami-harsh 🎉

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akagami-harsh, Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
@knative-prow knative-prow bot merged commit 3ef831c into knative:main Oct 18, 2023
35 of 40 checks passed
@akagami-harsh akagami-harsh deleted the fix-#7351 branch December 17, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@lberk lberk Awaiting requested review from lberk

@creydr creydr Awaiting requested review from creydr

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@Leo6Leo Leo6Leo

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase expiration buffer time of OIDCTokenProviders cache
5 participants
@akagami-harsh @pierDipi @Cali0707 @creydr @Leo6Leo